-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "websocketpp" on Mac OS X. #2370
Conversation
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (websocketpp) have been updated in this PR. Please review the changes. |
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Existing versions cannot be changed on BCR. Please create a new version with a |
Created |
Please add the new version to https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/websocketpp/metadata.json#L13 |
@carbo-asr And can you please sign the Google CLA. |
…on the operating system. This change fixes the build on Mac OS X. According to the original CMakeLists.txt, "rt" is not linked on Mac OS X. if (NOT APPLE) set (WEBSOCKETPP_PLATFORM_LIBS pthread rt) else() set (WEBSOCKETPP_PLATFORM_LIBS pthread) endif()
"All contributors are covered under a CLA with Google". |
Please fix
|
This change fixes the build on Mac OS X. According to the original CMakeLists.txt, "rt" is not linked on Mac OS X.