Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #2066

Merged
merged 1 commit into from
May 20, 2024
Merged

[email protected] #2066

merged 1 commit into from
May 20, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 20, 2024

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (grpc-httpjson-transcoding) have been updated in this PR. Please review the changes.

@mmorel-35
Copy link
Contributor Author

Please add usual labels :) .

@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels May 20, 2024
@mmorel-35 mmorel-35 marked this pull request as draft May 20, 2024 07:42
fmeum
fmeum previously approved these changes May 20, 2024
@bazel-io bazel-io dismissed fmeum’s stale review May 20, 2024 08:04

Require module maintainers' approval for newly pushed changes.

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented May 20, 2024

@fmeum ,
Any idea on how to "fix" windows executions ? Which flags are missing ?
I can remove windows from the presubmit but if it's only about a flag.

@mmorel-35 mmorel-35 marked this pull request as ready for review May 20, 2024 08:25
@mmorel-35 mmorel-35 requested a review from fmeum May 20, 2024 08:25
@fmeum fmeum merged commit 9996f84 into bazelbuild:main May 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants