Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --nolegacy_external_runfiles #72

Merged

Conversation

lalten
Copy link
Contributor

@lalten lalten commented Oct 31, 2024

bazelbuild/bazel#23574 is flipped for Bazel 8 but ctx.label.workspace_root still includes an external/ prefix. Replacing that with ../ makes rules_perl (and rules_cpan) work with Bazel 8 (bazelbuild/bazel-central-registry#3056).

@lalten lalten requested a review from skeletonkey as a code owner October 31, 2024 15:33
@lalten lalten changed the title Support --legacy_external_runfiles Support --nolegacy_external_runfiles Oct 31, 2024
perl/perl.bzl Outdated Show resolved Hide resolved
Co-authored-by: Fabian Meumertzheim <[email protected]>
@lalten
Copy link
Contributor Author

lalten commented Nov 5, 2024

@skeletonkey friendly bump.

This is blocking Bazel 8 compatibility for rules_cpan: bazelbuild/bazel-central-registry#3056

@skeletonkey skeletonkey merged commit e8d8285 into bazel-contrib:main Nov 6, 2024
1 check passed
@lalten lalten deleted the suport--nolegacy_external_runfiles branch November 6, 2024 13:43
@lalten
Copy link
Contributor Author

lalten commented Nov 6, 2024

Thanks @skeletonkey! Would it be possible to create a rules_perl 0.2.4 release? Then we can add that to the BCR and don't need to create a 0.2.3.bcr.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants