Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate transitive inputs #646

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix: propagate transitive inputs #646

merged 2 commits into from
Jul 3, 2024

Conversation

thesayyn
Copy link
Collaborator

@thesayyn thesayyn commented Jul 3, 2024

This has surfaced as bug in most of the places like #643, #642 (most likely).

The problem was that when symlinks were enabled on Bazel 7, the logic did not propagate the file dependencies correctly downstream which lead to some obscure errors i have mentioned above.

Now that we have some provider hierarchy, it makes me think if we should have a provider here, as requested in: #279

@thesayyn thesayyn requested review from alexeagle and gregmagolan July 3, 2024 15:47
@thesayyn thesayyn changed the base branch from main to 2.x July 3, 2024 15:47
@thesayyn thesayyn force-pushed the fix_transitive_inputs branch from 786ad0e to 0a2cbe9 Compare July 3, 2024 15:49
oci/private/image.bzl Outdated Show resolved Hide resolved
@thesayyn thesayyn merged commit 4b843d6 into 2.x Jul 3, 2024
18 checks passed
@thesayyn thesayyn deleted the fix_transitive_inputs branch July 3, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants