Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Implemented stamping created time #407

Closed
wants to merge 2 commits into from

Conversation

liningpan
Copy link
Contributor

Implemented stamping container created time with BUILD_TIMESTAMP

Closes #49

@liningpan liningpan marked this pull request as draft October 25, 2023 22:43
@thesayyn
Copy link
Collaborator

this goes against our pattern of provide us a file, which may or may not be stamped and we will used that file instead of teaching every attribute stamping.

@liningpan
Copy link
Contributor Author

So, does it mean you would prefer to have the created time provided in a file?

@thesayyn
Copy link
Collaborator

yes that's the approach we've taken.

@liningpan
Copy link
Contributor Author

Okay, we can set the created timestamp from a file now. I'm not sure what's the best way to add tests. Finding the file containing the timestamp requires one level of indirection (i.e. need to read the manifest file to find the blob).

Also, because timestamp is a single string, I don't know if there is a way to distinguish it from a label, which makes the semantics of this parameter different from others.

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like the right shape, maybe we would be okay with making the oci_image macro do more of this so there's less BUILD file for users to write

examples/created_timestamp/BUILD Outdated Show resolved Hide resolved
@thesayyn
Copy link
Collaborator

thesayyn commented May 8, 2024

@liningpan do you mind rebasing this PR against 2.x, and rename the attribute to created to follow the spec?

@thesayyn
Copy link
Collaborator

Closing this as inactive. Feel free to submit a new one

@thesayyn thesayyn closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oci_image should support stamping and creation time.
3 participants