-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add exposed_ports to oci_image #404
Conversation
Seems this fails with bazelmod. I'm investigating. |
Seems like under bzlmod, we're not using Line 14 in 1fce184
Is this deliberate? |
I have bumped the crane version in the MODULE.bazel of the e2e test. The test passes locally. Let's see what CI says. If you are concerned with the test not testing with the lowest supported crane version anymore, I'm happy to split it out. This is a separate discussion, but I find the choice of toolchain version management under bzlmod odd: I'd expect that by default, I'd get the latest known versions (but the ability to downgrade the versions if necessary). |
Thank you for adding this feature. Is there anything blocking this PR? |
We'll unblock this shortly this week. We need to upgrade the crane version which is an undocumented public API contract we never intended to expose. We'll have to document it and tell users to register their own toolchains if they rely on a specific version of crane. |
I don't think this in included in the latest When is the next release going out? |
Fixes #220.