Skip to content

Commit

Permalink
oci/defs.bzl: PR feedback: fix typo of attributes in docs.
Browse files Browse the repository at this point in the history
  • Loading branch information
reltuk committed Oct 16, 2023
1 parent 9821c5e commit d93944a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/image.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,6 @@ This is similar to the same-named target created by rules_docker's `container_im
| <a id="oci_image-env"></a>env | Environment variables provisioned by default to the running container. See documentation above. | <code>None</code> |
| <a id="oci_image-cmd"></a>cmd | Command & argument configured by default in the running container. See documentation above. | <code>None</code> |
| <a id="oci_image-entrypoint"></a>entrypoint | Entrypoint configured by default in the running container. See documentation above. | <code>None</code> |
| <a id="oci_image-kwargs"></a>kwargs | other named arguments to [oci_image_rule](#oci_image_rule) and [common rule attribtes](https://bazel.build/reference/be/common-definitions#common-attributes). | none |
| <a id="oci_image-kwargs"></a>kwargs | other named arguments to [oci_image_rule](#oci_image_rule) and [common rule attributes](https://bazel.build/reference/be/common-definitions#common-attributes). | none |


2 changes: 1 addition & 1 deletion docs/push.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,6 @@ Allows the remote_tags attribute to be a list of strings in addition to a text f
| :------------- | :------------- | :------------- |
| <a id="oci_push-name"></a>name | name of resulting oci_push_rule | none |
| <a id="oci_push-remote_tags"></a>remote_tags | a list of tags to apply to the image after pushing, or a label of a file containing tags one-per-line. See [stamped_tags](https://github.com/bazel-contrib/rules_oci/blob/main/examples/push/stamp_tags.bzl) as one example of a way to produce such a file. | <code>None</code> |
| <a id="oci_push-kwargs"></a>kwargs | other named arguments to [oci_push_rule](#oci_push_rule) and [common rule attribtes](https://bazel.build/reference/be/common-definitions#common-attributes). | none |
| <a id="oci_push-kwargs"></a>kwargs | other named arguments to [oci_push_rule](#oci_push_rule) and [common rule attributes](https://bazel.build/reference/be/common-definitions#common-attributes). | none |


6 changes: 3 additions & 3 deletions oci/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def oci_image(name, labels = None, annotations = None, env = None, cmd = None, e
cmd: Command & argument configured by default in the running container. See documentation above.
entrypoint: Entrypoint configured by default in the running container. See documentation above.
**kwargs: other named arguments to [oci_image_rule](#oci_image_rule) and
[common rule attribtes](https://bazel.build/reference/be/common-definitions#common-attributes).
[common rule attributes](https://bazel.build/reference/be/common-definitions#common-attributes).
"""
forwarded_kwargs = propagate_common_rule_attributes(kwargs)

Expand Down Expand Up @@ -156,7 +156,7 @@ def oci_push(name, remote_tags = None, **kwargs):
See [stamped_tags](https://github.com/bazel-contrib/rules_oci/blob/main/examples/push/stamp_tags.bzl)
as one example of a way to produce such a file.
**kwargs: other named arguments to [oci_push_rule](#oci_push_rule) and
[common rule attribtes](https://bazel.build/reference/be/common-definitions#common-attributes).
[common rule attributes](https://bazel.build/reference/be/common-definitions#common-attributes).
"""
forwarded_kwargs = propagate_common_rule_attributes(kwargs)

Expand Down Expand Up @@ -188,7 +188,7 @@ def oci_tarball(name, repo_tags = None, **kwargs):
See [stamped_tags](https://github.com/bazel-contrib/rules_oci/blob/main/examples/push/stamp_tags.bzl)
as one example of a way to produce such a file.
**kwargs: other named arguments to [oci_tarball_rule](#oci_tarball_rule) and
[common rule attribtes](https://bazel.build/reference/be/common-definitions#common-attributes).
[common rule attributes](https://bazel.build/reference/be/common-definitions#common-attributes).
"""
forwarded_kwargs = propagate_common_rule_attributes(kwargs)

Expand Down

0 comments on commit d93944a

Please sign in to comment.