Only run lint_tests on java_library not java_export #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running list_tests on java_export will run afoul by trying to run spotbugs on included dependency that will clearly fail like `java_proto_library`. Instead, the lint tests should only operate on the sources that comprise the `java_library` the export target eventually creates. fixes bazel-contrib#314
|
Validated this locally with |
shs96c
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running list_tests on java_export will run afoul by trying to run spotbugs on included dependency that will clearly fail like
java_proto_library.Instead, the lint tests should only operate on the sources that comprise the
java_librarythe export target eventually creates.fixes #314