Skip to content

Commit

Permalink
Remove format type
Browse files Browse the repository at this point in the history
  • Loading branch information
fzakaria committed Jul 15, 2024
1 parent 9fab462 commit c2d612d
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions java/private/checkstyle.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Checkstyle rule implementation
def _checkstyle_impl(ctx):
info = ctx.attr.config[CheckStyleInfo]
config = info.config_file
output_format = info.output_format

config_dir = paths.dirname(config.short_path)
maybe_cd_config_dir = ["cd {}".format(config_dir)] if config_dir else []
Expand All @@ -22,7 +21,6 @@ def _checkstyle_impl(ctx):
] + maybe_cd_config_dir + [
"$OLDPWD/{lib} -o checkstyle.xml -f xml -c {config} {srcs}".format(
lib = info.checkstyle.short_path,
output_format = output_format,
config = config.basename,
srcs = " ".join(["$OLDPWD/" + f.short_path for f in ctx.files.srcs]),
),
Expand Down Expand Up @@ -73,11 +71,6 @@ _checkstyle_test = rule(
[CheckStyleInfo],
],
),
"output_format": attr.string(
doc = "Output Format can be plain or xml. Defaults to plain",
values = ["plain", "xml"],
default = "plain",
),
"xslt": attr.label(
doc = "Path to the checkstyle2junit.xslt file",
allow_single_file = True,
Expand Down

0 comments on commit c2d612d

Please sign in to comment.