-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose toolchains #721
Conversation
Since we have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where these tools "sed" and "grep" come from
i am beginning to think that we should have another ruleset called rules_bash where bring in these tools hermetically. bazel-lib is becoming bloated. |
https://github.com/tweag/rules_sh is already maintained by some Nix experts 😉 |
@thesayyn this PR doesn't have actually fetching the tools yet. I wanted buy in on adding this before I put that work in. Plus I'm using this with Nix so I don't actually need that part for my stuff 😅 Regarding |
I think the |
3bc8b1e
to
0e63694
Compare
0e63694
to
4d509ec
Compare
@alexeagle / @thesayyn greatly scoped this down to just exporting the toolchain rules. Also happy to close this and just import them from |
I don't see on this thread an answer to: why would you want to load the toolchain symbols independently from registering them? Any increase to the public API surface constrains what maintainers are able to change, so it should come with an accompanying end-user benefit. |
I updated the overall PR description to cover the motivation, which is registering these toolchains without the binaries being provided by |
Sorry we never got to this one. Now that it's in bazel-contrib we have a wider maintainer base. Maybe @fmeum has an opinion about the toolchain_type's being exposed as public API, but I'm still inclined to say it's rare enough that you should just use the private API and deal with unlikely breaking changes |
Until the community stabilizes on best practices for "bunch of files" toolchains, I would also consider it too risky to expose these publicly (see bazelbuild/bazel#19645). |
Thanks @alexeagle and @fmeum. I'll just use it privately 🙂 |
New Feature
Exposed toolchains so that they can be used independently of registering them with the repo rules.
Test plan
Checked that my code is able to build while using the new public toolchain rules.