Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_deps should fail with a clear message when 2 modules that only differ in case are used #1954

Merged
merged 4 commits into from
Oct 11, 2024
Merged

go_deps should fail with a clear message when 2 modules that only differ in case are used #1954

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27a86cb
Don't hard fail if there's a second request to bazelize the same Go m…
Buzz-Lightyear Oct 8, 2024
e36eae9
Failing with a better error message
Buzz-Lightyear Oct 10, 2024
63ee5e2
Formatting the error string correctly
Buzz-Lightyear Oct 10, 2024
2dd2f39
Fixes for buildifier
fmeum Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/bzlmod/go_deps.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,6 +592,7 @@ def _go_deps_impl(module_ctx):
),
)

repos_processed = {}
for path, module in module_resolutions.items():
if hasattr(module, "module_name"):
# Do not create a go_repository for a Go module provided by a bazel_dep.
Expand All @@ -602,6 +603,14 @@ def _go_deps_impl(module_ctx):
# Do not create a go_repository for a dep shared with the non-isolated instance of
# go_deps.
continue
if module.repo_name in repos_processed:
fail("Go module {prev_path} and {path} will resolve to the same Bazel repo name: {name}. While Go allows modules to only differ in case, this isn't supported in Gazelle (yet). Please ensure you only use one of these modules in your go.mod(s)".format(
prev_path = repos_processed[module.repo_name],
path = path,
name = module.repo_name,
))

repos_processed[module.repo_name] = path
go_repository_args = {
"name": module.repo_name,
# Compared to the name attribute, the content of this attribute does not go through repo
Expand Down