Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1] Add headers support #42

Merged
merged 16 commits into from
Oct 1, 2023
Merged

[2.1] Add headers support #42

merged 16 commits into from
Oct 1, 2023

Conversation

rez1dent3
Copy link
Member

@rez1dent3 rez1dent3 commented Sep 26, 2023

Development of header transfer functionality:
#41
tokopedia/gripmock#144


Before release:

  • Human-readable input/headers;
  • Update readme.md;
  • Update documentation, add headers;
  • Test the ranking of stubs;

@rez1dent3 rez1dent3 linked an issue Sep 26, 2023 that may be closed by this pull request
@rez1dent3 rez1dent3 changed the title Add headers support [2.1] Add headers support Sep 26, 2023
@rez1dent3 rez1dent3 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 26, 2023
@rez1dent3
Copy link
Member Author

rez1dent3 commented Sep 30, 2023

I thought about it and I don’t really like the approach of moving headers to a separate input key. I'm thinking about other options.

There is no better idea, I'll leave it as it is.

@rez1dent3 rez1dent3 changed the base branch from latest to nightly October 1, 2023 15:11
@rez1dent3 rez1dent3 merged commit 5a24a86 into nightly Oct 1, 2023
4 checks passed
@rez1dent3 rez1dent3 deleted the headers-support branch October 3, 2023 20:16
@rez1dent3
Copy link
Member Author

tokopedia/gripmock#140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add headers support
1 participant