Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix v1.11, simplify by using install.sh + add matrix in actions #6

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

brokenpip3
Copy link
Collaborator

No description provided.

@brokenpip3 brokenpip3 marked this pull request as draft April 3, 2024 08:19
@brokenpip3 brokenpip3 marked this pull request as ready for review April 6, 2024 10:55
@brokenpip3 brokenpip3 changed the title Fix 1.11 fix v1.11, simplify by using install.sh + add matrix in actions Apr 6, 2024
@brokenpip3
Copy link
Collaborator Author

brokenpip3 commented Apr 6, 2024

@davdhacs thanks for your contribution!

@davdhacs @carlossg I simplified everything by using the upstream ./install.sh and cache one single directory. Also I added a matrix in all the gh tests actions to prevent differences between the bats version in the future.
I'm going to merge but before tagging a new release could you also please test it from main branch in your gh flow?
Thanks!

@brokenpip3 brokenpip3 merged commit ad7c577 into main Apr 6, 2024
29 of 31 checks passed
@carlossg
Copy link

carlossg commented Apr 8, 2024

@brokenpip3 it works fine, thanks!
carlossg/docker-maven#459

@brokenpip3
Copy link
Collaborator Author

Thanks a lot for letting me know, will tag a release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants