Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] br_cgu_servidores_executivo_federal #882

Merged
merged 19 commits into from
Nov 21, 2024
Merged

[refactor] br_cgu_servidores_executivo_federal #882

merged 19 commits into from
Nov 21, 2024

Conversation

tricktx
Copy link
Collaborator

@tricktx tricktx commented Nov 4, 2024 •
edited
Loading

Template Pull Requests - Pipeline

  • [Refactor]: Para mudanças no código que não alteram a funcionalidade.

Descrição do PR:

  • Refatorando todo o código do Pedro.
  • Adicionando o código dentro do crawler do CGU para reaproveitar algumas funções e facilitar futuras pipelines.
  • Excluir os arquivos anteriores como constants.py, flows.py, utils.py e tasks.py

Detalhes Técnicos:

  • A pipeline estava quebrando anteriormente devido a flow baixar todos os arquivos, a partir do crawler, eu utilizei uma forma para que o arquivo seja excluído após a sua utilização e também a utilização do gc.collect() para fazer a coleta do lixo.

Teste e Validações:

  • Relate os testes e validações relacionado aos dados/script:
    • Testado localmente
    • Testado na Cloud

@tricktx tricktx requested a review from a team November 4, 2024 21:34
@tricktx tricktx self-assigned this Nov 4, 2024
@tricktx tricktx marked this pull request as draft November 4, 2024 21:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

Coverage

Tests Skipped Failures Errors Time
8 7 💤 0 ❌ 0 🔥 11.827s ⏱️

@laura-l-amaral laura-l-amaral linked an issue Nov 5, 2024 that may be closed by this pull request
[fix] br_cgu_servidores_executivo_federal #873
Closed
@tricktx tricktx marked this pull request as ready for review November 8, 2024 14:53
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2024

@tricktx esse pull request tem conflitos 😩

@mergify mergify bot added the conflict label Nov 14, 2024
@tricktx tricktx merged commit d73e56d into main Nov 21, 2024
7 checks passed
@tricktx tricktx deleted the staging/fix-cgu-servidores branch November 21, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folhesgabriel folhesgabriel folhesgabriel approved these changes

Assignees

@tricktx tricktx

Labels
conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] br_cgu_servidores_executivo_federal
2 participants
@tricktx @folhesgabriel