Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] br_me_cnpj #878

Merged
merged 2 commits into from
Nov 1, 2024
Merged

[Refactor] br_me_cnpj #878

merged 2 commits into from
Nov 1, 2024

Conversation

folhesgabriel
Copy link
Contributor

@folhesgabriel folhesgabriel commented Oct 31, 2024 •
edited
Loading

Descrição do PR:

Este PR refatora a função data_url responsável por extrair a data mais recente de atualização dos dados

Detalhes Técnicos:

  • Altera a função data_url que faz o parsing da data mais recente de divugalção dos dados no endpoint da Receita Federal.
  • Retira a chamada da função da data_url dentro da task main e insere um novo parâmetro na função main para aproveitar o resultado da primeira chamada a API que extrai a data mais recente;
  • Insere novos parâmetros em todas as chamadas da task main no flow

Teste e Validações:

  • Relate os testes e validações relacionado aos dados/script:

    • Testado localmente
    • Testado na Cloud

    Caso haja algo relacionado aos testes que vale a pena informar:

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

Coverage

Tests Skipped Failures Errors Time
8 7 💤 0 ❌ 0 🔥 12.428s ⏱️

@folhesgabriel folhesgabriel self-assigned this Oct 31, 2024
@folhesgabriel folhesgabriel requested a review from a team October 31, 2024 13:33
tricktx
tricktx approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@tricktx tricktx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@folhesgabriel folhesgabriel merged commit 81d8cba into main Nov 1, 2024
7 checks passed
@folhesgabriel folhesgabriel deleted the staging/fix_cnpj branch November 1, 2024 01:18
@laura-l-amaral laura-l-amaral linked an issue Nov 1, 2024 that may be closed by this pull request
[fix] br_me_cnpj #880
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tricktx tricktx tricktx approved these changes

Assignees

@folhesgabriel folhesgabriel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] br_me_cnpj
2 participants
@folhesgabriel @tricktx