Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default template pull requests in the pipeline #867

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Default template pull requests in the pipeline #867

merged 5 commits into from
Oct 22, 2024

Conversation

tricktx
Copy link
Collaborator

@tricktx tricktx commented Sep 20, 2024 •
edited
Loading

  • Criando o template para os nossos prs no Gihtub.
  • Acredito que seja ideal padronizar as labels também.

@tricktx tricktx self-assigned this Sep 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

Coverage

Tests Skipped Failures Errors Time
8 7 💤 0 ❌ 0 🔥 10.266s ⏱️

@tricktx tricktx marked this pull request as draft September 20, 2024 20:56
@laura-l-amaral
Copy link
Contributor

@folhesgabriel @Winzen e @aspeddro o Trick fez uma primeira sugestão de modelo de PR pra gente aplicar nos próximos prs que vamos abrir. Acho que pra começar a conversa ficou bem bom, o próximo passo acho que seria deixar apenas os tópicos que a gente realmente vai preencher no template e os outros pontos deixar como uma documentação em algum ludar, pra não ser algo que só fica meio preenchido e muito longo ou repetitivo, o que vcs acham?

Minha intuição seria deixar os tópicos de

  • Descrição do PR:
  • Teste e Validações:
  • Revisão do código:

Tem mais alguma coisa que parece importante para vcs?

aspeddro
aspeddro reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@aspeddro aspeddro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixei alguns comentários.

@aspeddro
Copy link
Contributor

aspeddro commented Oct 3, 2024

Com esse template a proposta é que cada PR tenha essas seções ou é só um guia?

@tricktx tricktx linked an issue Oct 7, 2024 that may be closed by this pull request
As pessoas entendam como que a BD trata os dados #870
Open
@tricktx tricktx removed a link to an issue Oct 7, 2024
As pessoas entendam como que a BD trata os dados #870
Open
laura-l-amaral
laura-l-amaral approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@laura-l-amaral laura-l-amaral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por mim ajusta esse último detalhe dos revisaodres e fechamos

.github/pull_request_template.md Outdated Show resolved Hide resolved
@tricktx tricktx marked this pull request as ready for review October 22, 2024 19:41
@tricktx tricktx added the hacktoberfest-accepted Pull Requests aprovados na Hacktoberfest label Oct 22, 2024
@tricktx tricktx merged commit 96cf6c9 into main Oct 22, 2024
5 checks passed
@tricktx tricktx deleted the create_template_pr branch October 22, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspeddro aspeddro aspeddro left review comments

@laura-l-amaral laura-l-amaral laura-l-amaral approved these changes

@folhesgabriel folhesgabriel Awaiting requested review from folhesgabriel

@Winzen Winzen Awaiting requested review from Winzen

Assignees

@tricktx tricktx

Labels
hacktoberfest-accepted Pull Requests aprovados na Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tricktx @laura-l-amaral @aspeddro