Fix incorrect syntax for --evm flag and text errors in CLI docs #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
|
@EricNorberg is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wbnns
requested changes
Dec 5, 2024
wbnns
added
change(s) requested
* Update overview.md * Update security.md * Update using-base.md * Update cookie-policy.mdx * Update privacy-policy.md * Update onboarding.md * Update privacy-policy.md * Update overview.md * Update security.md * Update cookie-policy.mdx * Update overview.md * Update privacy-policy.md * Update privacy-policy.md
* Added GBM Domains logo to partner images * Added GBM Domains entry to ecosystem.json
* fix: spelling to British English * fix: typo in error message * fix: correct typo * fix: typos in smart contract tutorial * Update privacy-policy.md * Update hardhat-verify-sbs.md
…ion (base-org#1260) * Spelling and syntax errors * Typo * Spelling * typo
* fix: Correct spelling * fix: typo corrections in test files * fix: typos in function and struct names * fix: typos in security reporting documentation
This reverts commit e336f86.
* Update ecosystem.json * add mad logo * fmt
Fix typo in comment for generating Buildkite pipelines
stylistic improvements
…drop broken API3 urls (base-org#1350) * docs(notices): Add notice WRT deprecation of Geth archive snapshots * fix(docs): Broken links upstream on API3
* Fix typo in language selection dropdown message * Fix spelling error in feedback modal header/footer * Fix typo: `verifable` → `verifiable`
…/subcategories (base-org#1360) * update README steps for updating the base ecosystem page - switch tags to categories/subcategories * Update README.md Fix nested spacing of categories -> subcategories * fix subcategory value for "centralized exchange"
* Update 0_deploy-with-remix.md * Update deployment-to-base-sepolia-sbs.md
* typo Update privacy-policy.md The spelling error in the text. * typo Update terms-of-service.md There is one orthographic mistake. * Typo Update README.md Typographical issue: - In the line: **"You authorize and license to Coinbase"** It should be: **"You authorize and license Coinbase"** The preposition "to" is unnecessary here. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
The current documentation for the command npx thirdweb create app --evm uses an incorrect syntax for the --evm flag. Instead of using two hyphens (--), a single hyphen (-) is used, causing a syntax error when running the command.
Additionally, I have corrected typos and spelling errors in the text to improve clarity and readability.
Changes:
• Corrected the flag from -evm to --evm in the command description.
• Fixed various typos and spelling mistakes throughout the documentation.
Reason for Change:
• To fix a critical error where the command is not recognized by the CLI and fails to execute.
• To improve the overall readability and accuracy of the documentation.
Notes to reviewers
Please verify that the corrected command syntax aligns with the latest CLI version and ensure all other spelling and formatting changes are consistent.
How has it been tested?
• The corrected command was tested with the --evm flag, and it successfully executed as expected.