Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Computing wrong L2 hash #44

Merged
merged 3 commits into from
Sep 1, 2023
Merged

FIX: Computing wrong L2 hash #44

merged 3 commits into from
Sep 1, 2023

Conversation

wilsoncusack
Copy link
Collaborator

@wilsoncusack wilsoncusack commented Sep 1, 2023

Due to a difference in how Viem trim and Ethers stripZeroes we were computing the wrong tx hash for when value or mint or gas had a zero value in the deposit tx.

@wilsoncusack wilsoncusack temporarily deployed to verify September 1, 2023 18:53 — with GitHub Actions Inactive
@wilsoncusack wilsoncusack merged commit 9314e3e into main Sep 1, 2023
1 check passed
@wilsoncusack wilsoncusack deleted the wilson/fix-get-tx-hash branch September 1, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant