Chain exit: add support for upgrades and ownership transfer to the minimal proxy implementation #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdehoog
force-pushed
the
michael/chain-exit
branch
from
f92054e to
0356efd
Compare
mdehoog
force-pushed
the
michael/chain-exit
branch
from
0356efd to
237c839
Compare
chunter-cb
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our minimal proxy calls
getProxyImplementationon theProxyAdmin, which is essentially proxying a proxy (which allows us to upgrade multiple chains at once). However, it doesn't allow us to "detach" upgrades for a particular chain.This PR makes some changes to the minimal proxy, storing the implementation and owner in EIP-1967 state slots, and implementing the same interface as the op-stack's
Proxycontract. It still supports proxying a proxy by checking if the address stored in the implementation slot is itself a proxy (by passing it toProxyAdmin.getProxyImplementation).