Only log old block if going to propose

base-org · Oct 3, 2024 · ffde4fd · ffde4fd
1 parent ef3d011
commit ffde4fd
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/op-proposer/proposer/driver.go b/op-proposer/proposer/driver.go
@@ -262,14 +262,16 @@ func (l *L2OutputSubmitter) generateNextProposal(ctx context.Context, lastPropos
 		}
 	}
 
-	latestBlockHeader, err := l.L2Client.HeaderByNumber(l.ctx, nil)
-	if err != nil {
-		log.Warn("Failed to get latest block header", "err", err)
-		shouldPropose = false
-	} else if lastProposal.BlockRef.Number <= latestBlockHeader.Number.Uint64()-256 {
-		// only submit onchain if within the blockhash window
-		log.Warn("Not submitting proposal, block is too old", "block", lastProposal.BlockRef.Number, "latest", latestBlockHeader.Number.Uint64())
-		shouldPropose = false
+	if shouldPropose {
+		latestBlockHeader, err := l.L2Client.HeaderByNumber(l.ctx, nil)
+		if err != nil {
+			log.Warn("Failed to get latest block header", "err", err)
+			shouldPropose = false
+		} else if lastProposal.BlockRef.Number <= latestBlockHeader.Number.Uint64()-256 {
+			// only submit onchain if within the blockhash window
+			log.Warn("Not submitting proposal, block is too old", "block", lastProposal.BlockRef.Number, "latest", latestBlockHeader.Number.Uint64())
+			shouldPropose = false
+		}
 	}
 
 	return lastProposal, shouldPropose, nil