Fixed problem with unavailable details in a secured context. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed problem with unavailable details in a secured context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that there are multiple problems arise from the fact that the extension doesn't use messaging API instead of passing events. In my case, there was a problem outlined in #92 on an error inside svg file.
It turned out, that in a mixed context environment when making "document.dispatchEvent", the resulting event won't contain the detail object. Some info about this can be located at the bottom of this page: https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent
In this pull request, I improved the way the messages are being sent.