Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tests): adding testId prop & adding virtualized list & grid tests #53

Merged
merged 7 commits into from
Feb 5, 2024
Merged

feat(tests): adding testId prop & adding virtualized list & grid tests #53

merged 7 commits into from
Feb 5, 2024

Conversation

JulienIzz
Copy link
Contributor

@JulienIzz JulienIzz commented Feb 1, 2024 •
edited
Loading

This PR adds :

  • A testId prop for Virtualized Lists & Grids
  • New tests for virtualized list & grid
  • Absolute path in jest config
  • Snapshot resolver to nest them under tests in VSCode

@JulienIzz JulienIzz requested a review from pierpo February 1, 2024 14:49
@JulienIzz JulienIzz self-assigned this Feb 1, 2024
@JulienIzz JulienIzz force-pushed the test/adding-virtualized-list-test branch 3 times, most recently from 233d0f6 to 4bf86dc Compare February 1, 2024 16:28
@JulienIzz JulienIzz marked this pull request as draft February 2, 2024 08:21
@JulienIzz JulienIzz force-pushed the test/adding-virtualized-list-test branch 2 times, most recently from 37f29a4 to faf29f6 Compare February 2, 2024 16:14
@JulienIzz JulienIzz force-pushed the test/adding-virtualized-list-test branch from faf29f6 to 6d5ba10 Compare February 2, 2024 16:20
@JulienIzz JulienIzz changed the title test: adding virtualized list test feat(tests): adding testId prop & adding virtualized list & grid tests Feb 2, 2024
@JulienIzz JulienIzz marked this pull request as ready for review February 2, 2024 16:22
@JulienIzz JulienIzz force-pushed the test/adding-virtualized-list-test branch from 6d5ba10 to cef0268 Compare February 2, 2024 16:24
@JulienIzz JulienIzz force-pushed the test/adding-virtualized-list-test branch from cef0268 to 2e6573a Compare February 2, 2024 17:18
pierpo
pierpo reviewed Feb 5, 2024
View reviewed changes
.../src/spatial-navigation/components/virtualizedGrid/SpatialNavigationVirtualizedGrid.test.tsx Outdated
numberOfRenderedRows={5}
numberOfRowsVisibleOnScreen={3}
numberOfColumns={3}
testID="test-list"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could have been named differently but it's okay 😁

Suggested change
testID="test-list"
testID="test-grid"

pierpo
pierpo approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@pierpo pierpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could've added other tests for other scroll behaviours but it's fine, we can do it later 😁

@JulienIzz JulienIzz force-pushed the test/adding-virtualized-list-test branch from 2e6573a to df67f7f Compare February 5, 2024 10:07
@JulienIzz JulienIzz force-pushed the test/adding-virtualized-list-test branch from df67f7f to 63e750a Compare February 5, 2024 10:13
@pierpo pierpo merged commit fbbf4d6 into main Feb 5, 2024
1 check passed
@pierpo pierpo deleted the test/adding-virtualized-list-test branch February 5, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierpo pierpo pierpo approved these changes

Assignees

@JulienIzz JulienIzz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulienIzz @pierpo