chore: example of non virtualized manual grid #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienIzz
force-pushed
the
chore/non-virtualized-grid
branch
from
1f50df4 to
f1c7edb
Compare
pierpo
reviewed
Jan 30, 2024
pierpo
reviewed
Jan 30, 2024
pierpo
reviewed
Jan 30, 2024
pierpo
reviewed
Jan 30, 2024
|
|
||
| const ShortProgramList = () => { | ||
| const navigation = useNavigation<NativeStackNavigationProp<RootStackParamList>>(); | ||
| const programs = getPrograms().slice(0, 6); |
There was a problem hiding this comment.
Couldn't you use a lodash.chunk() to transform a 1D list into a 2D list with rows of size 6, and iterate on the rows?
Here you hardcoded 3 ShortProgramList, it would be better to generalize a little bit ;) (we're lucky to have static data here but it's not a real world example)
pierpo
reviewed
Jan 30, 2024
| ); | ||
|
|
||
| export const NonVirtualizedGridPage = () => { | ||
| const programsList = chunk(getPrograms(), 7); |
There was a problem hiding this comment.
You could extract this into a local constant in the file to make it more obvious 😁
Suggested change
| const programsList = chunk(getPrograms(), 7); | |
| const programsList = chunk(getPrograms(), ROW_SIZE); |
pierpo
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New page in the example app with a non-virtualized grid