Feat: Add onLongSelect #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierpo
reviewed
Sep 18, 2024
| }[evt.eventType]; | ||
|
|
||
| if (!mappedKey) { | ||
| return; | ||
| } | ||
|
|
||
| // We only want to handle keydown fon long select |
There was a problem hiding this comment.
"because it delays input and we don't want to add lag on all inputs"
(is that correct?)
There was a problem hiding this comment.
It is because we don't want to handle twice the long select (when keydown and when keyup)
There was a problem hiding this comment.
I will refine the comment
pierpo
reviewed
Sep 18, 2024
| @@ -6,7 +6,6 @@ import { | |||
| SpatialNavigationVirtualizedListRef, | |||
| } from 'react-tv-space-navigation'; | |||
| import { Page } from '../components/Page'; | |||
| import '../components/configureRemoteControl'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #36
Web
Enregistrement.de.l.ecran.2024-09-18.a.10.56.30.mov
AppleTV
Enregistrement.de.l.ecran.2024-09-18.a.11.00.38.mov
AndroidTV
Enregistrement.de.l.ecran.2024-09-18.a.11.09.25.mov