refactor: switch to object args for numberOfItemsVisibleOnScreenFunct…

…ions
bamlab · Sep 18, 2024 · 4654ff1 · 4654ff1
1 parent 7d970d8
commit 4654ff1
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 9 deletions.
diff --git a/packages/lib/src/spatial-navigation/components/virtualizedList/VirtualizedList.tsx b/packages/lib/src/spatial-navigation/components/virtualizedList/VirtualizedList.tsx
@@ -140,11 +140,11 @@ export const VirtualizedList = typedMemo(
     scrollBehavior = 'stick-to-start',
     testID,
   }: VirtualizedListProps<T>) => {
-    const numberOfItemsVisibleOnScreen = getNumberOfItemsVisibleOnScreen(
+    const numberOfItemsVisibleOnScreen = getNumberOfItemsVisibleOnScreen({
       data,
       listSizeInPx,
       itemSize,
-    );
+    });
 
     const numberOfItemsToRender = additionalItemsRendered
       ? additionalItemsRendered + numberOfItemsVisibleOnScreen

diff --git a/.../spatial-navigation/components/virtualizedList/helpers/getNumberOfItemsVisibleOnScreen.ts b/.../spatial-navigation/components/virtualizedList/helpers/getNumberOfItemsVisibleOnScreen.ts
@@ -1,4 +1,10 @@
-const getMinSizeOfItems = <T>(data: T[], itemSize: number | ((item: T) => number)) => {
+const getMinSizeOfItems = <T>({
+  data,
+  itemSize,
+}: {
+  data: T[];
+  itemSize: number | ((item: T) => number);
+}) => {
   if (typeof itemSize === 'number') {
     return itemSize;
   }
@@ -14,11 +20,15 @@ const getMinSizeOfItems = <T>(data: T[], itemSize: number | ((item: T) => number
 
   return minSize;
 };
-export const getNumberOfItemsVisibleOnScreen = <T>(
-  data: T[],
-  listSizeInPx: number,
-  itemSize: number | ((item: T) => number),
-) => {
-  const itemSizeToComputeRanges = getMinSizeOfItems(data, itemSize);
+export const getNumberOfItemsVisibleOnScreen = <T>({
+  data,
+  listSizeInPx,
+  itemSize,
+}: {
+  data: T[];
+  listSizeInPx: number;
+  itemSize: number | ((item: T) => number);
+}) => {
+  const itemSizeToComputeRanges = getMinSizeOfItems({ data, itemSize });
   return Math.floor(listSizeInPx / itemSizeToComputeRanges);
 };