chore(example): remove menu from pages without menu (#62)

bamlab · Feb 12, 2024 · 305675e · 305675e
1 parent 9588f16
commit 305675e
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 35 deletions.
diff --git a/packages/example/App.tsx b/packages/example/App.tsx
@@ -36,22 +36,24 @@ const RenderMenu = (props: BottomTabBarProps) => <Menu {...props} />;
 
 const TabNavigator = () => {
   return (
-    <Tab.Navigator
-      screenOptions={{
-        headerShown: false,
-      }}
-      initialRouteName="Home"
-      tabBar={RenderMenu}
-      sceneContainerStyle={{
-        marginLeft: theme.sizes.menu.closed,
-        backgroundColor: theme.colors.background.main,
-      }}
-    >
-      <Tab.Screen name="Home" component={Home} />
-      <Tab.Screen name="ProgramGridPage" component={ProgramGridPage} />
-      <Tab.Screen name="NonVirtualizedGridPage" component={NonVirtualizedGridPage} />
-      <Tab.Screen name="GridWithLongNodesPage" component={GridWithLongNodesPage} />
-    </Tab.Navigator>
+    <MenuProvider>
+      <Tab.Navigator
+        screenOptions={{
+          headerShown: false,
+        }}
+        initialRouteName="Home"
+        tabBar={RenderMenu}
+        sceneContainerStyle={{
+          marginLeft: theme.sizes.menu.closed,
+          backgroundColor: theme.colors.background.main,
+        }}
+      >
+        <Tab.Screen name="Home" component={Home} />
+        <Tab.Screen name="ProgramGridPage" component={ProgramGridPage} />
+        <Tab.Screen name="NonVirtualizedGridPage" component={NonVirtualizedGridPage} />
+        <Tab.Screen name="GridWithLongNodesPage" component={GridWithLongNodesPage} />
+      </Tab.Navigator>
+    </MenuProvider>
   );
 };
 
@@ -67,22 +69,21 @@ function App(): JSX.Element {
     <NavigationContainer>
       <ThemeProvider theme={theme}>
         <GoBackConfiguration />
-        <MenuProvider>
-          <Container width={width} height={height}>
-            <Stack.Navigator
-              screenOptions={{
-                headerShown: false,
-                contentStyle: {
-                  backgroundColor: theme.colors.background.main,
-                },
-              }}
-              initialRouteName="TabNavigator"
-            >
-              <Stack.Screen name="TabNavigator" component={TabNavigator} />
-              <Stack.Screen name="ProgramDetail" component={ProgramDetail} />
-            </Stack.Navigator>
-          </Container>
-        </MenuProvider>
+
+        <Container width={width} height={height}>
+          <Stack.Navigator
+            screenOptions={{
+              headerShown: false,
+              contentStyle: {
+                backgroundColor: theme.colors.background.main,
+              },
+            }}
+            initialRouteName="TabNavigator"
+          >
+            <Stack.Screen name="TabNavigator" component={TabNavigator} />
+            <Stack.Screen name="ProgramDetail" component={ProgramDetail} />
+          </Stack.Navigator>
+        </Container>
       </ThemeProvider>
     </NavigationContainer>
   );

diff --git a/packages/example/src/components/Menu/MenuContext.tsx b/packages/example/src/components/Menu/MenuContext.tsx
@@ -2,9 +2,7 @@ import { createContext, useContext, useMemo, useState } from 'react';
 
 const MenuContext = createContext<{ isOpen: boolean; toggleMenu: (isOpen: boolean) => void }>({
   isOpen: false,
-  toggleMenu: () => {
-    throw new Error('MenuContext not initialized');
-  },
+  toggleMenu: () => {},
 });
 
 export const MenuProvider = ({ children }: { children: React.ReactNode }) => {