feat(VirtualizedList)!: remove numberOfElementsVisibleOnScreen and numberOfElementsRendered props #402
JulienIzzAnnotations
10 errors and 1 warning
|
getRange for custom virtualized list › should throw an error if the numberOfRenderedItems is inferior to the numberOfItemsVisibleOnScreen + 2:
packages/lib/src/spatial-navigation/components/virtualizedList/helpers/getRange.test.ts#L73
expect(received).toThrowError()
Received function did not throw
at Object.toThrowError (src/spatial-navigation/components/virtualizedList/helpers/getRange.test.ts:73:7)
|
|
SpatialNavigationVirtualizedGrid › renders the correct number of item:
packages/lib/src/spatial-navigation/components/virtualizedGrid/SpatialNavigationVirtualizedGrid.test.tsx#L75
expect(received).toBeFalsy()
Received: {"_fiber": {"_debugHookTypes": null, "_debugNeedsRemount": false, "_debugOwner": [FiberNode], "_debugSource": null, "actualDuration": 0, "actualStartTime": -1, "alternate": null, "child": [FiberNode], "childLanes": 0, "deletions": null, "dependencies": null, "elementType": "Text", "flags": 0, "index": 0, "key": null, "lanes": 0, "memoizedProps": [Object], "memoizedState": null, "mode": 0, "pendingProps": [Object], "ref": null, "return": [FiberNode], "selfBaseDuration": 0, "sibling": null, "stateNode": [Object], "subtreeFlags": 0, "tag": 5, "treeBaseDuration": 0, "type": "Text", "updateQueue": null}}
at Object.toBeFalsy (src/spatial-navigation/components/virtualizedGrid/SpatialNavigationVirtualizedGrid.test.tsx:75:45)
|
|
SpatialNavigationVirtualizedGrid › renders the correct number of item:
packages/lib/src/spatial-navigation/components/virtualizedGrid/SpatialNavigationVirtualizedGrid.test.tsx#L54
expect(received).toMatchSnapshot()
Snapshot name: `SpatialNavigationVirtualizedGrid renders the correct number of item 1`
- Snapshot - 0
+ Received + 162
@@ -568,8 +568,170 @@
</Text>
</View>
</View>
</View>
</View>
+ <View
+ style={
+ {
+ "left": 0,
+ "position": "absolute",
+ "transform": [
+ {
+ "translateY": 500,
+ },
+ ],
+ }
+ }
+ >
+ <View
+ style={
+ [
+ undefined,
+ {
+ "flexDirection": "row",
+ },
+ ]
+ }
+ >
+ <View>
+ <View
+ accessibilityHint="button 16"
+ accessibilityLabel="button 16"
+ accessibilityRole="button"
+ accessibilityState={
+ {
+ "selected": false,
+ }
+ }
+ accessible={true}
+ isFocused={false}
+ style={
+ [
+ {
+ "backgroundColor": "transparent",
+ "borderRadius": 100,
+ "padding": 6,
+ },
+ undefined,
+ ]
+ }
+ >
+ <Text>
+ button 16
+ </Text>
+ </View>
+ </View>
+ <View>
+ <View
+ accessibilityHint="button 17"
+ accessibilityLabel="button 17"
+ accessibilityRole="button"
+ accessibilityState={
+ {
+ "selected": false,
+ }
+ }
+ accessible={true}
+ isFocused={false}
+ style={
+ [
+ {
+ "backgroundColor": "transparent",
+ "borderRadius": 100,
+ "padding": 6,
+ },
+ undefined,
+ ]
+ }
+ >
+ <Text>
+ button 17
+ </Text>
+ </View>
+ </View>
+ <View>
+ <View
+ accessibilityHint="button 18"
+ accessibilityLabel="button 18"
+ accessibilityRole="button"
+ accessibilityState={
+ {
+ "selected": false,
+ }
+ }
+ accessible={true}
+ isFocused={false}
+ style={
+ [
+ {
+ "backgroundColor": "transparent",
+ "borderRadius": 100,
+ "padding": 6,
+ },
+ undefined,
+ ]
+ }
+ >
+ <Text>
+ button 18
+ </Text>
+ </View>
+ </View>
+ </View>
+ </View>
+ <View
+ style={
+ {
+ "left": 0,
+ "position": "absolute",
+ "transform": [
+ {
+ "translateY": 600,
+ },
+ ],
+ }
+ }
+ >
+ <View
+ style={
+ [
+ undefined,
+ {
+ "flexDirection": "row",
+ },
+ ]
+ }
+ >
+ <View>
+ <View
+ accessibilityHint="button 19"
+ accessibilityLabel="button 19"
+ accessibilityRole="button"
+ accessibilityState={
+ {
+ "selected": false,
+ }
+ }
+ accessible={true}
+ isFocused={false}
+ style={
+ [
+
|
|
SpatialNavigationVirtualizedGrid › handles correctly RIGHT & DOWN and RENDERS new elements accordingly while deleting elements that are too far from scroll when on stick to start scroll:
packages/lib/src/spatial-navigation/components/virtualizedGrid/SpatialNavigationVirtualizedGrid.test.tsx#L105
expect(received).toBeFalsy()
Received: {"_fiber": {"_debugHookTypes": null, "_debugNeedsRemount": false, "_debugOwner": [FiberNode], "_debugSource": null, "actualDuration": 0, "actualStartTime": -1, "alternate": null, "child": [FiberNode], "childLanes": 0, "deletions": null, "dependencies": null, "elementType": "Text", "flags": 0, "index": 0, "key": null, "lanes": 0, "memoizedProps": [Object], "memoizedState": null, "mode": 0, "pendingProps": [Object], "ref": null, "return": [FiberNode], "selfBaseDuration": 0, "sibling": null, "stateNode": [Object], "subtreeFlags": 0, "tag": 5, "treeBaseDuration": 0, "type": "Text", "updateQueue": null}}
at Object.toBeFalsy (src/spatial-navigation/components/virtualizedGrid/SpatialNavigationVirtualizedGrid.test.tsx:105:45)
|
|
SpatialNavigationVirtualizedList › renders the correct number of item:
packages/lib/src/spatial-navigation/components/virtualizedList/SpatialNavigationVirtualizedList.test.tsx#L122
expect(received).toBeFalsy()
Received: {"_fiber": {"_debugHookTypes": null, "_debugNeedsRemount": false, "_debugOwner": [FiberNode], "_debugSource": null, "actualDuration": 0, "actualStartTime": -1, "alternate": null, "child": [FiberNode], "childLanes": 0, "deletions": null, "dependencies": null, "elementType": "Text", "flags": 0, "index": 0, "key": null, "lanes": 0, "memoizedProps": [Object], "memoizedState": null, "mode": 0, "pendingProps": [Object], "ref": null, "return": [FiberNode], "selfBaseDuration": 0, "sibling": null, "stateNode": [Object], "subtreeFlags": 0, "tag": 5, "treeBaseDuration": 0, "type": "Text", "updateQueue": null}}
at toBeFalsy (src/spatial-navigation/components/virtualizedList/SpatialNavigationVirtualizedList.test.tsx:122:21)
at tryCatch (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)
at Generator.<anonymous> (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)
at Generator.next (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)
at asyncGeneratorStep (../../node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:17)
at _next (../../node_modules/@babel/runtime/helpers/asyncToGenerator.js:17:9)
|
|
SpatialNavigationVirtualizedList › renders the correct number of item:
packages/lib/src/spatial-navigation/components/virtualizedList/SpatialNavigationVirtualizedList.test.tsx#L103
expect(received).toMatchSnapshot()
Snapshot name: `SpatialNavigationVirtualizedList renders the correct number of item 1`
- Snapshot - 0
+ Received + 80
@@ -223,8 +223,88 @@
<Text>
button 5
</Text>
</View>
</View>
+ <View
+ style={
+ {
+ "left": 0,
+ "position": "absolute",
+ "transform": [
+ {
+ "translateX": 500,
+ },
+ ],
+ }
+ }
+ >
+ <View
+ accessibilityHint="button 6"
+ accessibilityLabel="button 6"
+ accessibilityRole="button"
+ accessibilityState={
+ {
+ "selected": false,
+ }
+ }
+ accessible={true}
+ isFocused={false}
+ style={
+ [
+ {
+ "backgroundColor": "transparent",
+ "borderRadius": 100,
+ "padding": 6,
+ },
+ undefined,
+ ]
+ }
+ >
+ <Text>
+ button 6
+ </Text>
+ </View>
+ </View>
+ <View
+ style={
+ {
+ "left": 0,
+ "position": "absolute",
+ "transform": [
+ {
+ "translateX": 600,
+ },
+ ],
+ }
+ }
+ >
+ <View
+ accessibilityHint="button 7"
+ accessibilityLabel="button 7"
+ accessibilityRole="button"
+ accessibilityState={
+ {
+ "selected": false,
+ }
+ }
+ accessible={true}
+ isFocused={false}
+ style={
+ [
+ {
+ "backgroundColor": "transparent",
+ "borderRadius": 100,
+ "padding": 6,
+ },
+ undefined,
+ ]
+ }
+ >
+ <Text>
+ button 7
+ </Text>
+ </View>
+ </View>
</View>
</View>
</View>
at toMatchSnapshot (src/spatial-navigation/components/virtualizedList/SpatialNavigationVirtualizedList.test.tsx:103:20)
at tryCatch (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)
at Generator.<anonymous> (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)
at Generator.next (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)
at asyncGeneratorStep (../../node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:17)
at _next (../../node_modules/@babel/runtime/helpers/asyncToGenerator.js:17:9)
|
|
SpatialNavigationVirtualizedList › handles correctly RIGHT and RENDERS new elements accordingly while deleting elements that are too far from scroll:
packages/lib/src/spatial-navigation/components/virtualizedList/SpatialNavigationVirtualizedList.test.tsx#L142
expect(received).toBeFalsy()
Received: {"_fiber": {"_debugHookTypes": null, "_debugNeedsRemount": false, "_debugOwner": [FiberNode], "_debugSource": null, "actualDuration": 0, "actualStartTime": -1, "alternate": null, "child": [FiberNode], "childLanes": 0, "deletions": null, "dependencies": null, "elementType": "Text", "flags": 0, "index": 0, "key": null, "lanes": 0, "memoizedProps": [Object], "memoizedState": null, "mode": 0, "pendingProps": [Object], "ref": null, "return": [FiberNode], "selfBaseDuration": 0, "sibling": null, "stateNode": [Object], "subtreeFlags": 0, "tag": 5, "treeBaseDuration": 0, "type": "Text", "updateQueue": null}}
at toBeFalsy (src/spatial-navigation/components/virtualizedList/SpatialNavigationVirtualizedList.test.tsx:142:44)
at tryCatch (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)
at Generator.<anonymous> (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)
at Generator.next (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)
at asyncGeneratorStep (../../node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:17)
at _next (../../node_modules/@babel/runtime/helpers/asyncToGenerator.js:17:9)
|
|
SpatialNavigationVirtualizedList › stick-to-start › handles correctly stick-to-start lists:
packages/lib/src/spatial-navigation/components/virtualizedList/SpatialNavigationVirtualizedList.test.tsx#L219
expect(received).toBeFalsy()
Received: {"_fiber": {"_debugHookTypes": null, "_debugNeedsRemount": false, "_debugOwner": [FiberNode], "_debugSource": null, "actualDuration": 0, "actualStartTime": -1, "alternate": null, "child": [FiberNode], "childLanes": 0, "deletions": null, "dependencies": null, "elementType": "Text", "flags": 0, "index": 0, "key": null, "lanes": 0, "memoizedProps": [Object], "memoizedState": null, "mode": 0, "pendingProps": [Object], "ref": null, "return": [FiberNode], "selfBaseDuration": 0, "sibling": null, "stateNode": [Object], "subtreeFlags": 0, "tag": 5, "treeBaseDuration": 0, "type": "Text", "updateQueue": null}}
at toBeFalsy (src/spatial-navigation/components/virtualizedList/SpatialNavigationVirtualizedList.test.tsx:219:46)
at tryCatch (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)
at Generator.<anonymous> (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)
at Generator.next (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)
at asyncGeneratorStep (../../node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:17)
at _next (../../node_modules/@babel/runtime/helpers/asyncToGenerator.js:17:9)
|
|
SpatialNavigationVirtualizedList › handles correctly RIGHT and RENDERS new elements accordingly while deleting elements that are too far from scroll when on stick to end scroll:
packages/lib/src/spatial-navigation/components/virtualizedList/SpatialNavigationVirtualizedList.test.tsx#L348
expect(received).toBeFalsy()
Received: {"_fiber": {"_debugHookTypes": null, "_debugNeedsRemount": false, "_debugOwner": [FiberNode], "_debugSource": null, "actualDuration": 0, "actualStartTime": -1, "alternate": null, "child": [FiberNode], "childLanes": 0, "deletions": null, "dependencies": null, "elementType": "Text", "flags": 0, "index": 0, "key": null, "lanes": 0, "memoizedProps": [Object], "memoizedState": null, "mode": 0, "pendingProps": [Object], "ref": null, "return": [FiberNode], "selfBaseDuration": 0, "sibling": null, "stateNode": [Object], "subtreeFlags": 0, "tag": 5, "treeBaseDuration": 0, "type": "Text", "updateQueue": null}}
at toBeFalsy (src/spatial-navigation/components/virtualizedList/SpatialNavigationVirtualizedList.test.tsx:348:44)
at tryCatch (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)
at Generator.<anonymous> (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)
at Generator.next (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)
at asyncGeneratorStep (../../node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:17)
at _next (../../node_modules/@babel/runtime/helpers/asyncToGenerator.js:17:9)
|
|
SpatialNavigationVirtualizedList › handles correctly different item sizes:
packages/lib/src/spatial-navigation/components/virtualizedList/SpatialNavigationVirtualizedList.test.tsx#L504
expect(received).toBeFalsy()
Received: {"_fiber": {"_debugHookTypes": null, "_debugNeedsRemount": false, "_debugOwner": [FiberNode], "_debugSource": null, "actualDuration": 0, "actualStartTime": -1, "alternate": null, "child": [FiberNode], "childLanes": 0, "deletions": null, "dependencies": null, "elementType": "Text", "flags": 0, "index": 0, "key": null, "lanes": 0, "memoizedProps": [Object], "memoizedState": null, "mode": 0, "pendingProps": [Object], "ref": null, "return": [FiberNode], "selfBaseDuration": 0, "sibling": null, "stateNode": [Object], "subtreeFlags": 0, "tag": 5, "treeBaseDuration": 0, "type": "Text", "updateQueue": null}}
at toBeFalsy (src/spatial-navigation/components/virtualizedList/SpatialNavigationVirtualizedList.test.tsx:504:44)
at tryCatch (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:45:16)
at Generator.<anonymous> (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:133:17)
at Generator.next (../../node_modules/@babel/runtime/helpers/regeneratorRuntime.js:74:21)
at asyncGeneratorStep (../../node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:17)
at _next (../../node_modules/@babel/runtime/helpers/asyncToGenerator.js:17:9)
|
|
build (20.x)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|