Skip to content

Commit

Permalink
fix(eslint-plugin): config was broken because of missing char in rule…
Browse files Browse the repository at this point in the history
… name (#111)

* fix missing @ in rule name

* revert createRelease: "github"

it request a GH_TOKEN, which is painful if the `version` step is not done in CI
  • Loading branch information
Matthieu Gicquel authored Jan 9, 2024
1 parent 6fae2d7 commit fc9150f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
"private": false,
"message": "chore(release): Publish",
"conventionalCommits": true,
"allowBranch": "main",
"createRelease": "github"
"allowBranch": "main"
}
}
}
2 changes: 1 addition & 1 deletion packages/eslint-plugin/lib/configs/recommended.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const recommendedConfig = defineConfig({
"@typescript-eslint/indent": "off",
"@typescript-eslint/no-explicit-any": "error",
"@typescript-eslint/no-non-null-assertion": "error",
"typescript-eslint/no-shadow": "error",
"@typescript-eslint/no-shadow": "error",
"no-console": ["error", { allow: ["warn", "error"] }],
"no-return-await": "error",
"array-callback-return": "error",
Expand Down

0 comments on commit fc9150f

Please sign in to comment.