Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build Dependency for Docker #5156

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PatrickChenHZ
Copy link

Allow latest version/release to build in Docker.
Latest Revision require ffmpeg 7 to get libavcodec 61. Which means base image must be updated to ubuntu 24.10.

Allow latest version to build in Docker.
Latest Revision require ffmpeg 7 to get libvodec61. Which means base image must be updated to ubuntu 24.10
@lanewei120 lanewei120 requested a review from MackBambu November 12, 2024 00:12
@MackBambu
Copy link
Contributor

Allow latest version/release to build in Docker. Latest Revision require ffmpeg 7 to get libavcodec 61. Which means base image must be updated to ubuntu 24.10.

Isn't ffmpeg being built from source in docker?

@MackBambu MackBambu self-assigned this Nov 12, 2024
@PatrickChenHZ
Copy link
Author

PatrickChenHZ commented Nov 13, 2024

Allow latest version/release to build in Docker. Latest Revision require ffmpeg 7 to get libavcodec 61. Which means base image must be updated to ubuntu 24.10.

Isn't ffmpeg being built from source in docker?

Apparently not, when not explicitly installing FFMPEG it would complain libavcodec61 not found at runtime(build linux and therfore docker build would finish and report success). And when running with old dockerfile with ubuntu 22.04 the installed FFMPEG would not allign with version 61, as libavcodec61 require FFPMEG7 which is not supported on ubuntu 22

@MackBambu
Copy link
Contributor

#5252

@PatrickChenHZ
Copy link
Author

Given the nature and purpose of docker containers, I personally think it makes more sense to workaround the issue through building stage then adding unnecessary and potentially confusing arguments for runtime.

@MackBambu
Copy link
Contributor

MackBambu commented Nov 24, 2024

Given the nature and purpose of docker containers, I personally think it makes more sense to workaround the issue through building stage then adding unnecessary and potentially confusing arguments for runtime.

Agree

@PatrickChenHZ Make the suggested changes, and then it can be merged. Thank you!

PatrickChenHZ and others added 2 commits November 30, 2024 11:17
…s update a couple deprecated docker syntax. Also added more troubleshooting recommendations to DockerRun.sh
@PatrickChenHZ
Copy link
Author

Updated accordingly, please review.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants