-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SeMaWi release 2020.1 #248
Open
JosefAssad
wants to merge
71
commits into
ballerupgis:master
Choose a base branch
from
JosefAssad:2020_1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The style we're reverting out of works with newer Mediawiki versions, so we'll want that later. But for now we're just trying to re-stabilise SeMAWi.
Has a nice benefit of removing one mounted mutable.
One less file to worry about
Ahead of optimising the image build time.
Slims down subsequent layers
This slims down the image, speeds up image builds, and reduces the total LoC. A good change.
No one is really using it, but it works and there's a bit of history of interest in it. Little harm done keeping it.
This was breaking the mysql health check
If 50+ minutes load time is speeding up... We've downgraded mysql; version 8 was taking twice as long, and I see a lot of stories in github and on mediawiki of strange issues. So 5.7 looks to be the one to stick on for now. We're also splitting up dump importing and link rebuilding. It still takes a long time but there's results in the actual wiki a lot faster.
Useful for when we're scanning logs.
More secure like this. Not like we were dipping directly into the mysql from host anyhow.
Security is good, right?
This is the convention established at Ballerup. It's not a bad thing to standardise on, though of course it does sort of assume there's a downstream proxy.
These two capabilities are triaged out to facilitate a migration to external infrastructure. They can be reintroduced later on when the multi-municipality model settles.
Including not showing the MediaWiki sidebar.
So turns out, composer 2 has been released. We're using hirak/prestissimo (we should deprecate this, prestissimo is no longer supported), and that didn't play with composer 2. So we have to pin the composer install on the last release in the 1.* series.
Since we're going to be running iotwiki.dk also, that wiki has the walled garden settings disabled. Rather than operate with manually edited LocalSettings.php files, it's preferable to split that off as a tunable in `env-sample` and `.env`. That way both semawi and iotwiki can share the same codebase, and only the local .env will differ (as intended).
We have to do this because iotwiki also doesn't use it but semawi does. This commit helps us run both using an identical codebase with only difference being in the .env file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.