provide docker file for github builds with cmake #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ballaswag
reviewed
Apr 3, 2024
| @@ -102,7 +102,7 @@ libhv.a: | |||
|
|
|||
| libspdlog.a: | |||
| @mkdir -p $(SPDLOG_DIR)/build | |||
| @cmake -B $(SPDLOG_DIR)/build -S $(SPDLOG_DIR)/ | |||
| @cmake -B $(SPDLOG_DIR)/build -S $(SPDLOG_DIR)/ -DCMAKE_CXX_COMPILER=$(CXX) | |||
There was a problem hiding this comment.
Is this needed? Are line 5 and 6 where CC/CXX are defined no enough?
There was a problem hiding this comment.
In my local environment I could not get cmake to work without it, but perhaps that was only on the command line.
ballaswag
reviewed
Apr 3, 2024
| @@ -0,0 +1,18 @@ | |||
| FROM ubuntu:22.04 | |||
There was a problem hiding this comment.
Maybe just do FROM ballaswag/guppydev:latest then RUN DEBIAN_FRONTEND=noninteractive apt-get update && \ apt-get install -y --no-install-recommends cmake apt-get clean all && \ apt-get -y autoremove
Will try this and publish one with cmake
|
I am closing this, as it seems like you have it sorted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.