Add configuration option to disable spoolman integration #61
Conversation
|
Hello! Can you please help and explain how to install it? You're gonna be a big help to me |
|
Hi @georgiy364, Unfortunately the installation script will just pull down and install the latest release version not the version with this fix. Let me see if I can make the compiled version of the guppyscreen binary that you can install over the release version. Just double-checking, are you using spoolman? If so, you may be able to resolve the issue by making sure that all your filament entries in spool man have the vendor, material type, etc filled in. I'm working on a proper fix for the issue (this was pull request was really to buy some time to fix things properly). |
|
Thank you a lot! Yes, the issue was with the spoolman and your advice works perfectly! Appreciate |
| auto v = conf->get_json(conf->df() + "disable_spoolman"); | ||
| auto disable_spoolman = false; | ||
| if (!v.is_null()) { | ||
| if (v.template get<bool>()) { |
There was a problem hiding this comment.
this should be disable_spoolman = v.template get<bool>() because even if he attribute exists, it can be either true/false.
| } | ||
| Config *conf = Config::get_instance(); | ||
| auto v = conf->get_json(conf->df() + "disable_spoolman"); | ||
| auto disable_spoolman = false; |
There was a problem hiding this comment.
Line 74 to 79 can be replaced with auto disable_spoolman = !v.is_null() && v.template get<bool>();
There was a problem hiding this comment.
Much better than my code… which is why I should stick to architecture (boxes and fluffy clouds). 🤣 I'll update my pull request.
|
PR looks good overall. Even though you figured out the underlying issue relating to not checking for optional fields, it's nice to have the ability to disable spoolman completely. |
New printer configuration option "disable_spoolman" has been added to allow the spoolman integration to be disabled on a per-printer basis. Setting this option to true only disables the guppyscreen integration with spoolman and does not affect Moonraker. This is useful if incompatibility with a particular spoolman version prevents guppyscreen from initialising (such as issue #49).