Skip to content

balinttamas87/test-table-data-and-visualisation

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

25 Commits
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

To start the project

To see the service worker in action

The following has been built or done for this technical test

Things that I have experimented with for the first time

Some things that could be improved or added

To start the project

Clone this repo, cd into it and run

yarn

from the terminal to install dependencies listed in package.json.

Once all packages are installed you can run

yarn start

The app will run on the following url: http://localhost:3000.

To run the tests run

yarn test --verbose

(you might need to hit the letter "a" to run all tests when prompted)

To see the service worker in action

Once you have cloned the repo and installed all dependencies running yarn you can try the app in offline-first mode following the below steps.

  • run yarn build which will create a production build of the project and add the service worker defined in /src/sw-template.js.
  • install serve package globally by running yarn global add serve.
  • run / serve the production build via the command serve -s build. (The app will run on http://localhost:5000/ ).
  • Open the app on http://localhost:5000/ in incognito mode
  • Reload the page to cache the fetch results (assets are already cached at this point, but the fetch request's response is not)
  • Change Network to be offline in the Network tab of Dev Tools or in the Application tab selecting service-workers on the left hand-side and clicking the offline checkbox
  • Reload the page. You should see the app working as before. However, this time it should work in offline mode.

The following has been built or done for this technical test

In the following video you can watch the app in action and all its features

https://drive.google.com/file/d/1B0-SD_y1rWydML0aJ6pGiFi3Mh3nC8_D/view?usp=sharing

  • Display supplied JSON data in a table

  • Client-side pagination with "next" and "previous" buttons and "per page" (up to 100) input. If there is no previous or next page the buttons are disabled respectively

  • Sorting by date of birth, industry and salary when appropriate table header cell is clicked. The sorting direction changes with every click.

  • Display data as a set of charts (bar chart to show relationship between salary and experience, bar and pie charts for salary and years of experience comparison)

  • Update all charts when sorting or navigating within the table

  • Some tests for reducers and pagination component (Jest + react-testing-library)

Things that I have experimented with for the first time

  • redux-toolkit
  • organising code into features folder instead of components and containers folders.
  • chart.js via react-chartjs-2 library

Some things that could be improved or added

  • When sorting a new column by clicking on the table header cell we should always start sorting by the same direction (ascending or descending)
  • Add ability to clear sorting and filtering
  • When sorting empty values should be at the end of the list instead of in the beginning
  • Add "up" and "down" arrows to table column header cells to indicate sorting direction
  • Split ProfessionalTable component into a container to handle logic and smaller components to render UI
  • Move Chart out to be a separate feature from ProfessionalTable
  • Could find a better way to compose Chart components
  • Responsive mobile first UI
  • Table columns to be fixed-width so they don’t jump
  • Indicate loading of the data / table via skeleton UI
  • Create my own React components / wrappers for chart.js instead of using a library which does it for me.
  • More thorough testing
  • Remove legends or position them in a different way to make sure they don’t squash the pie chart when there is too much data or too many legends

The project has been bootstrapped with create-react-app. Please see below their readme file

This project was bootstrapped with Create React App, using the Redux and Redux Toolkit template.

Available Scripts

In the project directory, you can run:

yarn start

Runs the app in the development mode.
Open http://localhost:3000 to view it in the browser.

The page will reload if you make edits.
You will also see any lint errors in the console.

yarn test

Launches the test runner in the interactive watch mode.
See the section about running tests for more information.

yarn build

Builds the app for production to the build folder.
It correctly bundles React in production mode and optimizes the build for the best performance.

The build is minified and the filenames include the hashes.
Your app is ready to be deployed!

See the section about deployment for more information.

yarn eject

Note: this is a one-way operation. Once you eject, you can’t go back!

If you aren’t satisfied with the build tool and configuration choices, you can eject at any time. This command will remove the single build dependency from your project.

Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except eject will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own.

You don’t have to ever use eject. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it.

Learn More

You can learn more in the Create React App documentation.

To learn React, check out the React documentation.

Code Splitting

This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting

Analyzing the Bundle Size

This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size

Making a Progressive Web App

This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app

Advanced Configuration

This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration

Deployment

This section has moved here: https://facebook.github.io/create-react-app/docs/deployment

yarn build fails to minify

This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify

About

No description, website, or topics provided.

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published