Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise renderdoc.conf on all remote device platforms #3498

Closed
wants to merge 1 commit into from

Conversation

cmannett85-arm
Copy link
Collaborator

Aligns remote Linux with Android behaviour, by pushing the host's renderdoc.conf to the remote device. Preivously that was done only on Android via ADB, whereas now it is done over the server connection itself.

The slight regression here is that previously on Android the conf file was pushed before server start so the initial connection used the RemoteServer_TimeoutMS setting, whereas now that will be set upon first reconnection. All other settings are unaffected.

Aligns remote Linux with Android behaviour, by pushing the host's renderdoc.conf to the remote device.  Preivously that was done only on Android via ADB, whereas now it is done over the server connection itself.

The slight regression here is that previously on Android the conf file was pushed before server start so the initial connection used the `RemoteServer_TimeoutMS` setting, whereas now that will be set upon first reconnection.  All other settings are unaffected.
@baldurk
Copy link
Owner

baldurk commented Dec 9, 2024

I understand the reasoning for this change, but I don't think it's generally applicable and I think you should keep it locally.

We manage the config explicitly for Android primarily because we can know as a platform that it's by definition always remotely managed (you don't run the UI locally) and only ever has one client by its nature. As as side benefit because Android is such a terrible, awful, disaster of a platform even having to copy a file is painful so handling this ourselves is useful.

That primary reason doesn't hold for remote replay in general because you may be remote replaying on a machine that already has its own config and we can't unilaterally overwrite it. Also anywhere else but Android it's much easier to copy a file across or even run the UI to manage it locally on the remote.

@baldurk baldurk closed this Dec 9, 2024
@cmannett85-arm cmannett85-arm deleted the sync_conf branch December 10, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants