afterUpdate callback not provided the correct schema #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| var val = values[key]; | ||
| if (typeof val === 'object') { | ||
| // will stringify arrays and objects | ||
| values[key] = JSON.stringify(val); |
There was a problem hiding this comment.
This forces the values to change type, so I think this test will always fail.
|
Hi @chadxz, after looking at this I don't think this is the right place/way to test this issue as in your test it forces invalid values to be passed to Please take a look at balderdashy/waterline-adapter-tests#73, I believe that's the correct way of testing this issue. The build results show this issue only happens on sails-mysql and that's where this needs to be fixed. I'm closing this for now, please re-open if you disagree of if I missed something. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a failing test for #698