Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed unused methods on messages, removed commented lines on unittests #14

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

TRSSMG
Copy link

@TRSSMG TRSSMG commented Oct 17, 2024

fix: removed unused methods on messages, removed commented lines on unittests

@TRSSMG TRSSMG requested a review from Itshyphen October 17, 2024 07:33
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.41%. Comparing base (0c6b468) to head (a3f6d1d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   77.86%   82.41%   +4.54%     
==========================================
  Files          32       32              
  Lines        1649     1558      -91     
==========================================
  Hits         1284     1284              
+ Misses        365      274      -91     
Flag Coverage Δ
rust 82.41% <ø> (+4.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
contracts/asset_manager/src/contract.rs 90.46% <ø> (ø)
libs/soroban-rlp/src/balanced/address_utils.rs 84.61% <ø> (+42.84%) ⬆️
...n-rlp/src/balanced/messages/configure_protocols.rs 94.11% <ø> (+14.11%) ⬆️
...oroban-rlp/src/balanced/messages/cross_transfer.rs 95.23% <ø> (+11.90%) ⬆️
...rlp/src/balanced/messages/cross_transfer_revert.rs 93.54% <ø> (+15.17%) ⬆️
libs/soroban-rlp/src/balanced/messages/deposit.rs 55.31% <ø> (+13.38%) ⬆️
...oroban-rlp/src/balanced/messages/deposit_revert.rs 94.11% <ø> (+19.69%) ⬆️
...s/soroban-rlp/src/balanced/messages/withdraw_to.rs 94.11% <ø> (+19.69%) ⬆️

@TRSSMG TRSSMG requested a review from bishalbikram October 21, 2024 12:35
@bishalbikram bishalbikram added Development bug Something isn't working labels Oct 21, 2024
@bishalbikram bishalbikram changed the title removed unused methods on messages, removed commented lines on unittests chore: removed unused methods on messages, removed commented lines on unittests Oct 21, 2024
@bishalbikram bishalbikram changed the title chore: removed unused methods on messages, removed commented lines on unittests fix: removed unused methods on messages, removed commented lines on unittests Oct 21, 2024
@TRSSMG TRSSMG force-pushed the hotfix/unittest-coverage branch from b8bd5ec to 58ef3ef Compare October 21, 2024 13:03
@github-actions github-actions bot added the cicd label Oct 22, 2024
@bishalbikram bishalbikram force-pushed the hotfix/unittest-coverage branch from b300059 to a3f6d1d Compare October 22, 2024 11:20
@TRSSMG TRSSMG merged commit 72f8619 into main Oct 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cicd Development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants