Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add floor limit to assetManager #61

Merged

Conversation

AntonAndell
Copy link
Collaborator

Allow time rate limits on withdrawal of assets.

@AntonAndell AntonAndell linked an issue Mar 14, 2024 that may be closed by this pull request
@AntonAndell AntonAndell force-pushed the 31-circuit-breaker-on-asset-manager-rust-contracts branch 3 times, most recently from e22cbe9 to cf2b929 Compare March 14, 2024 06:46
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 90.35533% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 91.90%. Comparing base (811d521) to head (8c08f97).

❗ Current head 8c08f97 differs from pull request most recent head 0d56698. Consider uploading reports for the commit 0d56698 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   92.07%   91.90%   -0.17%     
==========================================
  Files          20       21       +1     
  Lines        2132     2323     +191     
==========================================
+ Hits         1963     2135     +172     
- Misses        169      188      +19     
Flag Coverage Δ
rust 91.90% <90.35%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ts/core-contracts/cw-asset-manager/src/contract.rs 93.93% <100.00%> (+0.67%) ⬆️
...racts/core-contracts/cw-asset-manager/src/error.rs 25.00% <ø> (ø)
...racts/core-contracts/cw-xcall-manager/src/error.rs 25.00% <ø> (ø)
contracts/cw-common/src/asset_manager_msg.rs 37.50% <ø> (ø)
contracts/cw-common/src/xcall_manager_msg.rs 88.88% <ø> (ø)
contracts/cw-common/src/rate_limit.rs 96.07% <96.07%> (ø)
contracts/cw-common/src/helpers.rs 85.29% <56.25%> (-8.94%) ⬇️
...ts/core-contracts/cw-xcall-manager/src/contract.rs 88.03% <54.54%> (-3.95%) ⬇️

Add RateLimits and Multisig governance actions
@AntonAndell AntonAndell force-pushed the 31-circuit-breaker-on-asset-manager-rust-contracts branch 2 times, most recently from 8c08f97 to 0d56698 Compare March 14, 2024 07:42
@AntonAndell AntonAndell requested review from nightowl121 and ibrizsabin and removed request for nightowl121 April 2, 2024 05:34
Copy link
Collaborator

@ibrizsabin ibrizsabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@AntonAndell AntonAndell merged commit 628805f into main Apr 3, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circuit Breaker on Asset Manager Rust contracts
2 participants