-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for denominated assets in asset manager #57
Merged
AntonAndell
merged 1 commit into
feature/balanced-xcall-manager
from
feature/add-denom-token-to-asset-manager
Jan 18, 2024
Merged
feat: Add support for denominated assets in asset manager #57
AntonAndell
merged 1 commit into
feature/balanced-xcall-manager
from
feature/add-denom-token-to-asset-manager
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonAndell
force-pushed
the
feature/add-denom-token-to-asset-manager
branch
from
December 28, 2023 09:40
5b14a01
to
5fdb4e9
Compare
AntonAndell
changed the title
add support for denominates assets in asset manager
feat: Add support for denominated assets in asset manager
Dec 28, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/balanced-xcall-manager #57 +/- ##
==================================================================
- Coverage 92.27% 92.22% -0.06%
==================================================================
Files 20 20
Lines 1865 2018 +153
==================================================================
+ Hits 1721 1861 +140
- Misses 144 157 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AntonAndell
force-pushed
the
feature/add-denom-token-to-asset-manager
branch
2 times, most recently
from
December 28, 2023 09:47
7a25112
to
95c966d
Compare
ibrizsabin
reviewed
Dec 29, 2023
ibrizsabin
reviewed
Dec 29, 2023
ibrizsabin
reviewed
Dec 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few concerns that needs attention.
ibrizsabin
approved these changes
Dec 29, 2023
AntonAndell
force-pushed
the
feature/add-denom-token-to-asset-manager
branch
from
December 29, 2023 08:29
95c966d
to
84a1b6d
Compare
AntonAndell
force-pushed
the
feature/balanced-xcall-manager
branch
from
January 2, 2024 11:05
7a9a212
to
93b3484
Compare
AntonAndell
force-pushed
the
feature/add-denom-token-to-asset-manager
branch
from
January 2, 2024 11:16
84a1b6d
to
1a821a4
Compare
AntonAndell
force-pushed
the
feature/balanced-xcall-manager
branch
2 times, most recently
from
January 2, 2024 11:19
bfb3cdb
to
2c4bbe2
Compare
AntonAndell
force-pushed
the
feature/add-denom-token-to-asset-manager
branch
2 times, most recently
from
January 2, 2024 11:27
517b1b4
to
4d19f88
Compare
AntonAndell
force-pushed
the
feature/balanced-xcall-manager
branch
from
January 2, 2024 11:29
2c4bbe2
to
6c5aa45
Compare
AntonAndell
force-pushed
the
feature/add-denom-token-to-asset-manager
branch
from
January 2, 2024 11:41
4d19f88
to
5453a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.