Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for denominated assets in asset manager #57

Conversation

AntonAndell
Copy link
Collaborator

No description provided.

@AntonAndell AntonAndell force-pushed the feature/add-denom-token-to-asset-manager branch from 5b14a01 to 5fdb4e9 Compare December 28, 2023 09:40
@AntonAndell AntonAndell changed the title add support for denominates assets in asset manager feat: Add support for denominated assets in asset manager Dec 28, 2023
@AntonAndell AntonAndell added the enhancement New feature or request label Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (6c5aa45) 92.27% compared to head (5453a5b) 92.22%.

Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                         @@
##           feature/balanced-xcall-manager      #57      +/-   ##
==================================================================
- Coverage                           92.27%   92.22%   -0.06%     
==================================================================
  Files                                  20       20              
  Lines                                1865     2018     +153     
==================================================================
+ Hits                                 1721     1861     +140     
- Misses                                144      157      +13     
Flag Coverage Δ
rust 92.22% <92.16%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...racts/core-contracts/cw-asset-manager/src/error.rs 25.00% <ø> (ø)
contracts/cw-common/src/asset_manager_msg.rs 37.50% <ø> (ø)
...ts/core-contracts/cw-asset-manager/src/contract.rs 92.69% <92.16%> (-0.27%) ⬇️

@AntonAndell AntonAndell force-pushed the feature/add-denom-token-to-asset-manager branch 2 times, most recently from 7a25112 to 95c966d Compare December 28, 2023 09:47
Copy link
Collaborator

@ibrizsabin ibrizsabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few concerns that needs attention.

@AntonAndell AntonAndell force-pushed the feature/add-denom-token-to-asset-manager branch from 95c966d to 84a1b6d Compare December 29, 2023 08:29
@AntonAndell AntonAndell force-pushed the feature/balanced-xcall-manager branch from 7a9a212 to 93b3484 Compare January 2, 2024 11:05
@AntonAndell AntonAndell force-pushed the feature/add-denom-token-to-asset-manager branch from 84a1b6d to 1a821a4 Compare January 2, 2024 11:16
@AntonAndell AntonAndell force-pushed the feature/balanced-xcall-manager branch 2 times, most recently from bfb3cdb to 2c4bbe2 Compare January 2, 2024 11:19
@AntonAndell AntonAndell force-pushed the feature/add-denom-token-to-asset-manager branch 2 times, most recently from 517b1b4 to 4d19f88 Compare January 2, 2024 11:27
@AntonAndell AntonAndell force-pushed the feature/balanced-xcall-manager branch from 2c4bbe2 to 6c5aa45 Compare January 2, 2024 11:29
@AntonAndell AntonAndell force-pushed the feature/add-denom-token-to-asset-manager branch from 4d19f88 to 5453a5b Compare January 2, 2024 11:41
@AntonAndell AntonAndell merged commit 4d109b4 into feature/balanced-xcall-manager Jan 18, 2024
6 checks passed
@AntonAndell AntonAndell linked an issue Feb 21, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for ICS-20 tokens to asset manager
2 participants