This repository has been archived by the owner on Oct 26, 2021. It is now read-only.
Feature - Lock the app until a time has elapsed [NOT MERGE YET] #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cerezo074
changed the title
Rolvar
suggested changes
Jan 22, 2018
| return false | ||
| } | ||
|
|
||
| guard interval.isValid else { |
There was a problem hiding this comment.
this guard could be in the same guard statement above, I mean, both return false and nothing between them, so you could do this:
guard let interval = interval,
interval.isValid else {
return false
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request adding a feature or fixing a bug?
Feature
Does this pull request close an issue? If so, which one?
Nop
What does this pull request do? What does it change?
This pr enables the feature to lock de app after a time selected by the user, design is missing on iOS and Mac OS, even the feature was tested on both platform and works well only Mac platform shows option on UI due to the settings view has more specification regarding lock the app. Waiting for instructions if I have to able the option on UI for iOS app.