feat: add MarkDelegationAsTransitioned method #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented MarkDelegationAsTransformed method in V1Database to mark delegations as transformed in the db. - Updated V1DBClient interface to include the new method. - Modified DelegationDocument and DelegationPublic structures to include a Transformed field. - Added logic in V2Service to check and mark V1 delegations as transformed during active staking handling. - Updated mock implementations for V1DBClient to support the new method.
gusin13
approved these changes
Dec 1, 2024
jeremy-babylonlabs
force-pushed
the
102-mark-phase-1-delegation-transformed
branch
from
db71897
to
9355422
Compare
jeremy-babylonlabs
changed the title
jrwbabylonlab
approved these changes
Dec 3, 2024
gusin13
reviewed
Dec 3, 2024
internal/v2/db/client/deelgation.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| update := bson.M{"$set": bson.M{"transitioned": true}} |
There was a problem hiding this comment.
wont' this be is_transitioned as per the model?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #102
transitionedfield.