feat: support fp stats #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusin13
force-pushed
the
gusin13/add-fp-stats
branch
from
06a8f27
to
d5cc704
Compare
| @@ -34,12 +35,35 @@ func (s *V2Service) GetOverallStats(ctx context.Context) (*OverallStatsPublic, * | |||
| return nil, types.NewInternalServiceError(err) | |||
| } | |||
|
|
|||
| activeStakersCount, err := s.DbClients.V2DBClient.GetActiveStakersCount(ctx) | |||
There was a problem hiding this comment.
this will have performance issue when we have very big data set tho.
There was a problem hiding this comment.
right, added a todo for now and logged ticket
#165
jrwbabylonlab
approved these changes
Dec 2, 2024
gusin13
force-pushed
the
gusin13/add-fp-stats
branch
from
def89be
to
6d749e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr
Note:
re - active_finality_providers and total_finality_providers in v2/overall-stats
for now i am querying directly the finality_provider_details indexer db to get this data but ideally this should come from indexer->queues->api->stats db