Skip to content
This repository has been archived by the owner on Nov 4, 2021. It is now read-only.

PR that fixes locking issues with newer versions of elasticsearch #353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raymondtri
Copy link

This closes this issue: https://github.com/babenkoivan/scout-elasticsearch-driver/issues/323

Please refer to that thread for more information, as the <7.4.0 is no longer relevant.

@ibrahimab
Copy link

What is the status of this pull request?

@rekrios
Copy link

rekrios commented May 28, 2020

Elastic 7.4 : 'Specifying types in urls has been deprecated'

So, maybe there shouldn't be 'type' payloads for elastic >= 7.4

@RodrigoGalter
Copy link

Please, merge this PR.

@rekrios
Copy link

rekrios commented Jun 9, 2020

Please, merge this PR.

this fix wouldn't be correct without 'type' fixes, no ? It's useless if you just have changed version in composer.json

Copy link

@rekrios rekrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 'type' fixes coz it is deprecated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants