This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 311
aggregation feature #267
Open
martianoff
wants to merge
8
commits into
babenkoivan:v3.12.0
Choose a base branch
from
alexkovt:feature/aggregation
base: v3.12.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
aggregation feature #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exactly what I need. |
Josh-Mus
approved these changes
Jan 22, 2020
When will this change be merged @babenkoivan ? Thanks |
@babenkoivan Any problem with this PR ? |
Can you provide some explanation about the feature? Also it would be nice if you update the readme with some documentation for this feature. |
@maksimru If you want your work to come true, a last effort on the doc ;-) |
@alexkovt thank you for great implementation. Can you provide some small piece of instruction that is explaining how to use this (aggregation) changes? It is definitely lot of effort of course, without explanation it is worthless, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on closed pull request #47 with minimal changes