Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] separate image message & OpenCV image classification, use dictionary for classes #12

Merged

Conversation

minhnh
Copy link
Member

@minhnh minhnh commented Jul 23, 2019

Changelog

  • break the classify function into classify and classify_np_images, where the latter may classify a list of OpenCV images and the former a list of sensor_msgs/Image messages
  • use dictionary to keep track of classes in ImageClassifier, update relevant function and documentation

Motivation

  • allow for classifying OpenCV images directly, which is needed by Refactor mdr_find_people mas_domestic_robotics#152 for cutout face and body images
  • make keeping track of classes for ImageClassifier consistent with ImageDetector and more flexible (e.g. allow for skipping classes)

QA

  • tested locally with the object recognition service and corresponding test script

roslaunch mdr_object_recognition object_recognition.launch
rosrun mas_perception_libs -t ${IMAGE_DIR} -s ${SERVICE_NAME} ${MODEL_NAME}

@minhnh minhnh added the refactor move code around to increase maintainability, flexibility,... label Jul 23, 2019
@minhnh minhnh requested review from alex-mitrevski and argenos July 23, 2019 20:40
@minhnh minhnh self-assigned this Jul 23, 2019
@minhnh minhnh changed the title [Refactor] separate image message and OpenCV image classification WIP: [Refactor] separate image message and OpenCV image classification Jul 23, 2019
@minhnh minhnh changed the title WIP: [Refactor] separate image message and OpenCV image classification [Refactor] separate image message & OpenCV image classification, use dictionary for classes Jul 23, 2019
docs/python_package.md Outdated Show resolved Hide resolved
Co-Authored-By: Argentina Ortega Sáinz <[email protected]>
@minhnh minhnh merged commit eb0c545 into b-it-bots:kinetic Oct 16, 2019
@minhnh minhnh deleted the refactor/separate_ros_img_classification branch October 16, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor move code around to increase maintainability, flexibility,...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants