Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKS: Fix default nodepool upgrade settings #2067

Merged

Conversation

caiovbraga
Copy link
Contributor

@caiovbraga caiovbraga commented Oct 2, 2024

2068

PR Checklist


Description

The current module has a bug if values for upgrade_settings are set

│ Error: Unsupported attribute
│ 
│   on .terraform/modules/caf/modules/compute/aks/aks.tf line 80, in resource "azurerm_kubernetes_cluster" "aks":
│   80:         max_surge = upgrade_settings.value.max_surge
│     ├────────────────
│     │ upgrade_settings.value is 1
│ 
│ Can't access attributes on a primitive-typed value (number).

I'm also adding the optional settings in the upgrade_settings block

Does this introduce a breaking change

  • YES
  • NO

Testing

@arnaudlh arnaudlh added the bug Something isn't working label Oct 15, 2024
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh added this to the 5.7.14 milestone Oct 15, 2024
@arnaudlh arnaudlh modified the milestones: 5.7.14, 5.7.15 Nov 11, 2024
@arnaudlh arnaudlh linked an issue Nov 11, 2024 that may be closed by this pull request
1 task
@arnaudlh arnaudlh merged commit 55946c7 into aztfmod:main Nov 11, 2024
180 of 192 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bug report- Fix default nodepool upgrade settings
2 participants