Included the change to auto remediate the Redis Cache BRS #255

jaiswalricha · 2022-08-18T07:58:30Z

Hey Saurabh,

Please help to review and approve. thanks

VamseeInala · 2022-09-01T07:24:03Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

-        Write-Host "Connecting to Azure account..."
-        Connect-AzAccount -Subscription $SubscriptionId -ErrorAction Stop | Out-Null
-        Write-Host "Connected to Azure account." -ForegroundColor $([Constants]::MessageType.Update)
+        Write-Host "No active Azure login session found. Exiting..." -ForegroundColor $([Constants]::MessageType.Error)


Can we also tell the user what action to perform in this case?

Hey Vamsee, tried to add msg as ' please try to reconnect your azure account as 'connect-az account' with subs id.
pls help to have a look

VamseeInala · 2022-09-01T07:25:28Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

+    {
+        if (-not (Test-Path -Path $Path))
+        {
+            Write-Host "File containing failing controls details [$($Path)] not found. Skipping remediation..." -ForegroundColor $([Constants]::MessageType.Error)


What action user has to take in this case? Can we guide the user better?

Especially in auto remediation, last option which user should have is to reach out to us.

added the msg to verify if path is correct and failed control are placed on the same path

VamseeInala · 2022-09-07T08:03:19Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

+                $logResource.Add("ResourceName",($_.ResourceName))	
+                $logResource.Add("Reason","Encountered error while disabling Non-SSL port on Redis Cache(s) configuration")    	
+                $logSkippedResources += $logResource	
+                Write-Host "Skipping this resource..." -ForegroundColor $([Constants]::MessageType.Warning)	


What is the user action needed in this case?

this will require some research as this is on the control level and how it failed.

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

saurabhgautam-msft · 2022-09-22T05:15:36Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1


    # Connect to Azure account
    $context = Get-AzContext

    if ([String]::IsNullOrWhiteSpace($context))
    {
-        Write-Host $([Constants]::SingleDashLine)


why removed these lines?

saurabhgautam-msft · 2022-09-22T05:16:07Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1


    if ($PerformPreReqCheck)
    {
        try
        {
-            Write-Host "[Step 1 of 4] Validating and installing the modules required to run the script and validating the user..."


Isn't this was better way for describing this step?

saurabhgautam-msft · 2022-09-22T05:18:37Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

    Write-Host $([Constants]::SingleDashLine)

    # list for storing Redis Cache(s) for which Non-SSL port is enabled.
    $RedisCacheWithNonSSLPortEnabled = @()

-    Write-Host "Separating Redis Cache(s) for which Non-SSL port is enabled..."
+    Write-Host "Separate Redis Cache(s) for which Non-SSL port is enabled."


This isn't a step right? so separating was better here also make it info

saurabhgautam-msft · 2022-09-22T05:21:28Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

@@ -306,10 +382,14 @@ function Disable-NonSSLPortOnRedisCache
    if ($totalRedisCacheWithNonSSLPortEnabled  -eq 0)
    {
        Write-Host "No Redis Cache(s) found with Non-SSL port enabled.. Exiting..." -ForegroundColor $([Constants]::MessageType.Warning)
-        break
+        Write-Host $([Constants]::DoubleDashLine)


Since here we are returning the control back/ending execution.

Though we have 0 redis cache having non ssl port enabled but if we have any redis cache resource we should show that in log file right? as they all skipped.

So add that code block here =>

if($AutoRemediation -and $totalCloudService -gt 0)
{
$logFile = "LogFiles"+ $($TimeStamp) + "\log_" + $($SubscriptionId) +".json"
$log = Get-content -Raw -path $logFile | ConvertFrom-Json
foreach($logControl in $log.ControlList){
if($logControl.ControlId -eq $controlIds){
$logControl.RemediatedResources=$logRemediatedResources
$logControl.SkippedResources=$logSkippedResources
}
}
$log | ConvertTo-json -depth 100 | Out-File $logFile
}

similar to this

saurabhgautam-msft · 2022-09-22T05:23:43Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

@@ -363,12 +445,14 @@ function Disable-NonSSLPortOnRedisCache
            if($userInput -ne "Y")


if(-not force) one should have an wrapper condtion of if(-not $Autoremediation) as for autoremediation feature we won't be asking input from user again

saurabhgautam-msft · 2022-09-22T05:24:54Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

@@ -439,7 +585,7 @@ function Disable-NonSSLPortOnRedisCache
        Write-Host $([Constants]::DoubleDashLine)


Step 4 of 4 :

remove ... from last

saurabhgautam-msft · 2022-09-22T05:25:34Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

        }

        if ($($RedisCacheSkipped | Measure-Object).Count -gt 0)
        {
-            Write-Host "`nError disabling Non-SSL port on the following Redis Cache(s)in the subscription:" -ForegroundColor $([Constants]::MessageType.Error)
+
            $RedisCacheSkipped | Format-Table -Property $colsProperty -Wrap


No need to display table when autoremediation feature is in use.

saurabhgautam-msft · 2022-09-22T05:25:53Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

-
-            $RedisCacheRemediated | Format-Table -Property $colsProperty -Wrap
+
+           $RedisCacheRemediated | Format-Table -Property $colsProperty -Wrap


Not needed when autoremediation feature is in use

saurabhgautam-msft · 2022-09-22T05:26:46Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

        }
    }
    else
    {
-        Write-Host "[Step 1 of 3] Validating the user..." 
+        Write-Host "[Step 1 of 3] Validate the user..." 


remove '...' from end

saurabhgautam-msft · 2022-09-22T05:27:14Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

        }
    }
    else
    {
-        Write-Host "[Step 1 of 3] Validating the user..." 
+        Write-Host "[Step 1 of 3] Validate the user..." 


Similarly from Step 1 of 3, remove '...' from end.

saurabhgautam-msft · 2022-09-22T05:27:33Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

@@ -508,12 +654,14 @@ function Enable-NonSSLPortOnRedisCache
        catch
        {
            Write-Host "Error occurred while setting up prerequisites. Error: $($_)" -ForegroundColor $([Constants]::MessageType.Error)


Error: [$($_)]

saurabhgautam-msft · 2022-09-22T05:28:06Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1


    Write-Host $([Constants]::DoubleDashLine)
-    Write-Host "[Step 2 of 3] Preparing to fetch all Redis Cache(s)..."
+    Write-Host "[Step 2 of 3] Prepare to fetch all Redis Cache(s)..."


remove '...' from end

saurabhgautam-msft · 2022-09-22T05:28:29Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

    }

-    Write-Host "Fetching all Redis Cache(s) from" -NoNewline
+    Write-Host "Fetch all Redis Cache(s) from" -NoNewline


here it will be fetching as we are performing an action

saurabhgautam-msft · 2022-09-22T05:28:41Z

Scripts/RemediationScripts/Remediate-DisableNonSSLPortOnRedisCache.ps1

@@ -582,7 +733,7 @@ function Enable-NonSSLPortOnRedisCache


    Write-Host $([Constants]::DoubleDashLine)
-    Write-Host "[Step 3 of 3] Enabling SSL port for all Redis Cache(s) in the Subscription..."
+    Write-Host "[Step 3 of 3] Enable SSL port for all Redis Cache(s) in the Subscription..."


remove '...' from end

Included the change to auto remediate the Redis Cache BRS

1767ff3

jaiswalricha assigned saurabhgautam-msft, pranchalsomani and jaiswalricha and unassigned saurabhgautam-msft and pranchalsomani Aug 18, 2022

jaiswalricha requested review from pranchalsomani and VamseeInala August 19, 2022 10:03

VamseeInala reviewed Sep 7, 2022

View reviewed changes

jaiswalricha added 2 commits September 14, 2022 21:50

added the space between two words.

7b5d17c

Solved PR comments

ac0c6b6

saurabhgautam-msft reviewed Sep 22, 2022

View reviewed changes

pranchalsomani assigned aakashpahwa-msft Sep 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Included the change to auto remediate the Redis Cache BRS #255

Included the change to auto remediate the Redis Cache BRS #255

jaiswalricha commented Aug 18, 2022

VamseeInala Sep 1, 2022

jaiswalricha Sep 19, 2022

VamseeInala Sep 1, 2022

jaiswalricha Sep 19, 2022

VamseeInala Sep 7, 2022

jaiswalricha Sep 19, 2022

saurabhgautam-msft Sep 22, 2022

saurabhgautam-msft Sep 22, 2022

saurabhgautam-msft Sep 22, 2022

saurabhgautam-msft Sep 22, 2022

saurabhgautam-msft Sep 22, 2022

saurabhgautam-msft Sep 22, 2022

saurabhgautam-msft Sep 22, 2022

saurabhgautam-msft Sep 22, 2022

saurabhgautam-msft Sep 22, 2022

saurabhgautam-msft Sep 22, 2022

saurabhgautam-msft Sep 22, 2022

saurabhgautam-msft Sep 22, 2022

saurabhgautam-msft Sep 22, 2022

saurabhgautam-msft Sep 22, 2022

		@@ -363,12 +445,14 @@ function Disable-NonSSLPortOnRedisCache
		if($userInput -ne "Y")

		@@ -439,7 +585,7 @@ function Disable-NonSSLPortOnRedisCache
		Write-Host $([Constants]::DoubleDashLine)


		$RedisCacheRemediated \| Format-Table -Property $colsProperty -Wrap

		$RedisCacheRemediated \| Format-Table -Property $colsProperty -Wrap

Included the change to auto remediate the Redis Cache BRS #255

Are you sure you want to change the base?

Included the change to auto remediate the Redis Cache BRS #255

Conversation

jaiswalricha commented Aug 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment