Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR title/meta with react-helmet #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kronthto
Copy link

Provides an example implementation of react-helmet including pre-rendering on the server.

I don't have yarn installed so I couldn't update the lock-file.

In development mode, the {{HELMET_%}} strings do not get replaced and therefore show on the top of the document. I tried <!--{{HELMET_%}}--> (and the same in the replace function), but react-scripts removes comments in the build command, so there was nothing to replace. Maybe someone has an idea on how to solve this better?

Ref #10

@ayroblu
Copy link
Owner

ayroblu commented Aug 6, 2017

There's a better way to do this than react helmet I think, writing another article

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants