-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hot reload + api / production on 3000 to match CRA #1
base: master
Are you sure you want to change the base?
Conversation
Okay, so made some changes, here's my thoughts (didn't test my changes) Once changes are tested I'll merge in |
Cool looks good. Yeah I started with just concurrently / hot reloading / proxy then thought I ought to make sure the API proxy was working before submitting. Tried to follow what you had started with the commented out saga stuff. I wasn't sure res.json() returned status at all or just the data so the saga code may have to change now. |
Yeah, I haven't gotten to the point where I actually need sagas. I leave the code there in case its needed cause it's common practice, but it's such a pain and 99% unnecessary |
I liked your approach to avoiding an eject while adding SSR / API server. I wanted to enhance development by getting the API running beside the CRA dev server. Also added in hot reloading for containers / reducers.
After I got that working for my project I thought I'd make the changes to yours and submit a pull request for anyone who finds this moving forward.
I ended up fleshing out your api enough to confirm the api server responds during development. When you go to the Second Page it fetches /api/users/1 and updates the store. Returning to the first page will show the new email address. It's pretty bare bones.