Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] AppVeyor updates #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

vespakoen
Copy link

Hey hey!

I have been trying to make prebuilds of either node-iohook or the iohook package.
It's been rough so far =)

However, I at least got it to start compiling something, and producing actual compilation errors that hopefully lead us to a solution soon.

Here is the failing build: https://ci.appveyor.com/project/vespakoen/node-iohook/build/3/job/1l0gc19lrpw11vwj

And here are the relevant errors:

node-iohook.obj : error LNK2019: unresolved external symbol _hook_set_dispatch_proc referenced in function "public: virtual void __thiscall HookProcessWorker::Execute(class Nan::AsyncProgressWorkerBase<struct _uiohook_event>::ExecutionProgress const &)" (?Execute@HookProcessWorker@@UAEXABVExecutionProgress@?$AsyncProgressWorkerBase@U_uiohook_event@@@Nan@@@Z) [C:\projects\node-iohook\build\node-iohook.vcxproj]
node-iohook.obj : error LNK2019: unresolved external symbol _hook_run referenced in function "public: virtual void __thiscall HookProcessWorker::Execute(class Nan::AsyncProgressWorkerBase<struct _uiohook_event>::ExecutionProgress const &)" (?Execute@HookProcessWorker@@UAEXABVExecutionProgress@?$AsyncProgressWorkerBase@U_uiohook_event@@@Nan@@@Z) [C:\projects\node-iohook\build\node-iohook.vcxproj]
node-iohook.obj : error LNK2019: unresolved external symbol _hook_stop referenced in function "public: void __thiscall HookProcessWorker::Stop(void)" (?Stop@HookProcessWorker@@QAEXXZ) [C:\projects\node-iohook\build\node-iohook.vcxproj]

Compiling iohook with the settings in this pull, yields something like this: https://ci.appveyor.com/project/vespakoen/iohook/build/job/i06vnvm59na05k0d

I know I am getting closer, but this is literally the first time I am compiling C++ on Windows, so I don't really know what I am doing ;)

It would also be great if you can shed some light on the reason for there being 2 packages trying to achieve the same thing, I guess one of you simply didn't notice the other package was around?

I hope this helps!

@ayoubserti
Copy link
Owner

Hi @vespakoen,
Sorry to let your PR without comment. if you can make it compiling on AppVeyor and Travis-CI I will merge it in prompt.

Please go a head and add necessary changes.

-Ayb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants