Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop long seq even if not sample packing #2211

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NanoCode012
Copy link
Collaborator

Description

empti reported in discord https://discord.com/channels/1104757954588196865/1111279858136383509/1320021873878372436 that sequences are truncated not dropped if sample_packing is off. This PR tries to fix that. RL path seems fine, only SFT is missing.

[ ] Check for pretraining case
[ ] Check handling for if skip_prepare: True

Motivation and Context

How has this been tested?

Untested!

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

@winglian
Copy link
Collaborator

I swore someone just submitted a PR that was merged to remove this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants